Cross-ref SimpleNamespace, snapshot sys.modules, add regression test

claude · claude · commit c99f273558e8 · 2026-02-13T02:15:36.000Z
- Use :class:`~types.SimpleNamespace` cross-ref in RELEASE.rst - Wrap sys.modules.items() in list() to snapshot against concurrent mutation - Add regression test for unhashable sys.modules entries https://claude.ai/code/session_01PQkqWu11828t7hwzAyR1sZ
diff --git a/hypothesis-python/RELEASE.rst b/hypothesis-python/RELEASE.rst
@@ -1,4 +1,4 @@
 RELEASE_TYPE: patch
 
 This patch fixes a crash when :obj:`sys.modules` contains unhashable values,
-such as ``types.SimpleNamespace`` objects (:issue:`4660`).
+such as :class:`~types.SimpleNamespace` objects (:issue:`4660`).
diff --git a/hypothesis-python/src/hypothesis/internal/conjecture/providers.py b/hypothesis-python/src/hypothesis/internal/conjecture/providers.py
@@ -312,7 +312,7 @@ def _get_local_constants() -> Constants:
     # with other threads loading a module before we set _sys_modules_len.
     if (sys_modules_len := len(sys.modules)) != _sys_modules_len:
         new_modules = []
-        for name, module in sys.modules.items():
+        for name, module in list(sys.modules.items()):
             try:
                 seen = module in _seen_modules
             except TypeError:
diff --git a/hypothesis-python/tests/conjecture/test_local_constants.py b/hypothesis-python/tests/conjecture/test_local_constants.py
@@ -9,6 +9,8 @@
 # obtain one at https://mozilla.org/MPL/2.0/.
 
 import math
+import sys
+from types import SimpleNamespace
 
 import pytest
 
@@ -92,3 +94,14 @@ def f(n):
         pass
 
     f()
+
+
+def test_unhashable_sys_modules_entry(monkeypatch):
+    # Regression test for https://github.com/HypothesisWorks/hypothesis/issues/4660
+    # Some packages (e.g. cog) place unhashable objects like SimpleNamespace
+    # in sys.modules. This should not crash _get_local_constants.
+    monkeypatch.setattr(providers, "_sys_modules_len", None)
+    monkeypatch.setattr(providers, "_seen_modules", set())
+    monkeypatch.setitem(sys.modules, "_unhashable_test_mod", SimpleNamespace())
+
+    providers._get_local_constants()
