Address review feedback: restore lint check with whitelist, revert taste changes

veeceey · veeceey · commit a83564923d0b · 2026-02-10T02:50:13.000-08:00
Per Liam-DeVoe and Zac-HD's feedback:
- Revert the "that that" -&gt; "the" change in api-style.rst (intentional construct)
- Re-add duplicate-word lint check, but only for unambiguously incorrect
  duplicates: the, as, a, to, because
- Use deferred exit so all lint issues are reported before failing
diff --git a/guides/api-style.rst b/guides/api-style.rst
@@ -149,7 +149,7 @@ The main reasons for preferring this style are:
 * Errors at test import time tend to throw people and be correspondingly hard
   for them to debug.
   There's an expectation that errors in your test code result in failures in
-  your tests, and the fact that the test code happens to be defined in a
+  your tests, and the fact that that test code happens to be defined in a
   decorator doesn't seem to change that expectation for people.
 * Things like deprecation warnings etc. localize better when they happen
   inside the test - test runners will often swallow them or put them in silly
diff --git a/tooling/src/hypothesistooling/__main__.py b/tooling/src/hypothesistooling/__main__.py
@@ -80,6 +80,10 @@ def lint():
     pip_tool("ruff", "check", ".")
     codespell(*(p for p in tools.all_files() if not p.name.endswith("by-domain.txt")))
 
+    from textwrap import indent
+
+    failed = False
+
     matches = subprocess.run(
         r"git grep -En '@(dataclasses\.)?dataclass\(.*\)' "
         "| grep -Ev 'frozen=.*slots=|slots=.*frozen='",
@@ -88,10 +92,23 @@ def lint():
         text=True,
     ).stdout
     if matches:
-        from textwrap import indent
-
         print("\nAll dataclass decorators must pass slots= and frozen= arguments:")
         print(indent(matches, "    "))
+        failed = True
+
+    dupes = subprocess.run(
+        r"git grep -nP '\b(the|as|a|to|because)\s+\1\b'"
+        " -- ':!*.svg' ':!*.png' ':!*.jpg' ':!*.sketch'",
+        shell=True,
+        capture_output=True,
+        text=True,
+    ).stdout
+    if dupes:
+        print("\nDuplicate word(s) found:")
+        print(indent(dupes, "    "))
+        failed = True
+
+    if failed:
         sys.exit(1)
 
 
