Fix rare BytesWarning

Zac-HD · Zac-HD · commit 8235f7059fce · 2022-04-10T12:16:49.000-07:00
diff --git a/hypothesis-python/src/hypothesis/strategies/_internal/strategies.py b/hypothesis-python/src/hypothesis/strategies/_internal/strategies.py
@@ -10,7 +10,7 @@
 
 import sys
 import warnings
-from collections import defaultdict
+from collections import abc, defaultdict
 from random import shuffle
 from typing import (
     Any,
@@ -811,17 +811,22 @@ def pack(self, x):
         raise NotImplementedError(f"{self.__class__.__name__}.pack()")
 
     def do_draw(self, data: ConjectureData) -> Ex:
-        for _ in range(3):
-            i = data.index
-            try:
-                data.start_example(MAPPED_SEARCH_STRATEGY_DO_DRAW_LABEL)
-                result = self.pack(data.draw(self.mapped_strategy))
-                data.stop_example()
-                return result
-            except UnsatisfiedAssumption:
-                data.stop_example(discard=True)
-                if data.index == i:
-                    raise
+        with warnings.catch_warnings():
+            if isinstance(self.pack, type) and issubclass(
+                self.pack, (abc.Mapping, abc.Set)
+            ):
+                warnings.simplefilter("ignore", BytesWarning)
+            for _ in range(3):
+                i = data.index
+                try:
+                    data.start_example(MAPPED_SEARCH_STRATEGY_DO_DRAW_LABEL)
+                    result = self.pack(data.draw(self.mapped_strategy))
+                    data.stop_example()
+                    return result
+                except UnsatisfiedAssumption:
+                    data.stop_example(discard=True)
+                    if data.index == i:
+                        raise
         raise UnsatisfiedAssumption()
 
     @property
diff --git a/hypothesis-python/tests/cover/test_lookup.py b/hypothesis-python/tests/cover/test_lookup.py
@@ -713,6 +713,11 @@ def test_generic_collections_only_use_hashable_elements(typ, data):
     data.draw(from_type(typ))
 
 
+@given(st.sets(st.integers() | st.binary(), min_size=2))
+def test_no_byteswarning(_):
+    pass
+
+
 def test_hashable_type_unhashable_value():
     # Decimal("snan") is not hashable; we should be able to generate it.
     # See https://github.com/HypothesisWorks/hypothesis/issues/2320
