Skip to content
This repository was archived by the owner on Nov 22, 2023. It is now read-only.

refactor: use global fetch#620

Merged
ImRodry merged 1 commit intomainfrom
refactor-undici
Jun 18, 2022
Merged

refactor: use global fetch#620
ImRodry merged 1 commit intomainfrom
refactor-undici

Conversation

@ImRodry
Copy link
Copy Markdown
Member

@ImRodry ImRodry commented Feb 6, 2022

Please describe the changes this PR makes and why it should be merged

undici's fetch is coming to node in v18: nodejs/node#41749
Not putting this in production because undici is using many experimental node features for now
Ref: 6ce33eb

In this PR:

  • Code changes have been tested against on a separate test bot

@ImRodry ImRodry force-pushed the main branch 2 times, most recently from c19e441 to 63b8f34 Compare April 18, 2022 14:51
@ImRodry ImRodry force-pushed the refactor-undici branch 2 times, most recently from 862a4e4 to a348619 Compare April 25, 2022 12:36
@ImRodry ImRodry changed the title refactor: switch to undici refactor: use global fetch Jun 18, 2022
undici's fetch is coming to node in v18: nodejs/node#41749
Not putting this in production because undici is using many experimental node features for now
Ref: 6ce33eb
@ImRodry ImRodry marked this pull request as ready for review June 18, 2022 22:06
@ImRodry ImRodry merged commit a30fd2e into main Jun 18, 2022
@ImRodry ImRodry deleted the refactor-undici branch June 18, 2022 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant