-
Notifications
You must be signed in to change notification settings - Fork 3.3k
chore: FIT-1002: Improve Dropdown types, options handling and add to storybook #8880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8880 +/- ##
===========================================
- Coverage 65.85% 57.79% -8.07%
===========================================
Files 820 561 -259
Lines 64433 40864 -23569
Branches 11023 11033 +10
===========================================
- Hits 42433 23616 -18817
+ Misses 21996 17244 -4752
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/fm sync |
…-studio into fb-fit-1002-properties
|
/fm sync |
This pull request introduces several improvements to the dropdown component and its styling, focusing on enhanced alignment and positioning logic, better SCSS class management, and minor API updates. The main themes are improved dropdown positioning using CSS anchor positioning with intelligent fallbacks, SCSS class prefixing for consistency, and small API/documentation tweaks.
Dropdown positioning and alignment improvements:
openUpwardForShortViewportprop is now documented as obsolete, since positioning is handled automatically by CSS anchor positioning and fallbacks.props.stylelast, so user-supplied styles can override alignment-based positioning if needed.SCSS and class naming improvements:
ls-(except for Ant Design classes), improving BEM-style consistency and avoiding class name collisions.flex-direction: columnto better support scrollable inner content, replacing the previousoverflow: autoapproach.API and typing updates:
DropdownTriggerPropsinterface now explicitly includes achildrenprop for clarity and better typing.Dropdownexport is now correctly typed with a staticTriggerproperty for improved TypeScript compatibility and backward compatibility.