Skip to content

Conversation

@ricardoantoniocm
Copy link
Contributor

@ricardoantoniocm ricardoantoniocm commented Oct 27, 2025

This pull request updates and expands the design token system, focusing on typography and color consistency across the UI. The main changes include introducing new font size tokens, adjusting existing typography scale mappings, and updating color tokens for improved accuracy. These updates ensure more granular and standardized control over typography and color usage throughout the application.

Design Token and Typography Updates:

  • Added new font size tokens for 18 and 20 to design-tokens.json, tokens.scss, and the JS token mapping, allowing for more granular typography scaling. [1] [2] [3]
  • Updated the mapping of semantic font size tokens (such as title, headline, and display sizes) to use the new and adjusted font size values, both in design-tokens.json and tokens.scss, ensuring consistency across the design system. [1] [2]

Color Token Adjustments:

  • Changed the accent-sand-subtlest color token to use a lighter value (sand-000 instead of sand-100) in both the design tokens JSON and SCSS files, for improved color accuracy and consistency. [1] [2]

Token Value Precision:

  • Standardized the precision of letter spacing values in design-tokens.json by rounding to two decimal places, making the tokens easier to read and maintain. [1] [2]

Component Update:

  • Updated the DangerZone component to use the new headline "medium" size instead of "large", reflecting the revised typography scale. This will ensure this heading matches the headings on other settings pages.

@ricardoantoniocm ricardoantoniocm self-assigned this Oct 27, 2025
@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit c496022
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/690251da6db5b300087ad2bd

@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit c496022
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/690251daa41ad10009f6eaf1

@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit c496022
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/690251da71e9c00008d33265

@github-actions github-actions bot added the feat label Oct 27, 2025
@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for label-studio-playground canceled.

Name Link
🔨 Latest commit c496022
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/690251da4a074b00084f5b97

@ricardoantoniocm ricardoantoniocm marked this pull request as ready for review October 27, 2025 21:33
@ricardoantoniocm ricardoantoniocm requested a review from a team as a code owner October 27, 2025 21:33
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.97%. Comparing base (5175000) to head (c496022).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8724      +/-   ##
===========================================
- Coverage    61.36%   59.97%   -1.40%     
===========================================
  Files          790      551     -239     
  Lines        60687    39003   -21684     
  Branches     10316    10316              
===========================================
- Hits         37243    23391   -13852     
+ Misses       23441    15609    -7832     
  Partials         3        3              
Flag Coverage Δ
lsf-e2e 54.22% <ø> (?)
lsf-integration 50.69% <ø> (+0.04%) ⬆️
lsf-unit 8.34% <ø> (ø)
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardoantoniocm ricardoantoniocm requested a review from a team October 29, 2025 02:26
@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented Oct 29, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/ui/src/assets/icons/rows-4.svg

@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented Oct 29, 2025

/git merge

Workflow run
Successfully merged: 1 file changed, 9 insertions(+), 1 deletion(-)

@robot-ci-heartex robot-ci-heartex merged commit 237bc7b into develop Oct 29, 2025
171 of 186 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-871 branch October 29, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants