You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request updates and expands the design token system, focusing on typography and color consistency across the UI. The main changes include introducing new font size tokens, adjusting existing typography scale mappings, and updating color tokens for improved accuracy. These updates ensure more granular and standardized control over typography and color usage throughout the application.
Design Token and Typography Updates:
Added new font size tokens for 18 and 20 to design-tokens.json, tokens.scss, and the JS token mapping, allowing for more granular typography scaling. [1][2][3]
Updated the mapping of semantic font size tokens (such as title, headline, and display sizes) to use the new and adjusted font size values, both in design-tokens.json and tokens.scss, ensuring consistency across the design system. [1][2]
Color Token Adjustments:
Changed the accent-sand-subtlest color token to use a lighter value (sand-000 instead of sand-100) in both the design tokens JSON and SCSS files, for improved color accuracy and consistency. [1][2]
Token Value Precision:
Standardized the precision of letter spacing values in design-tokens.json by rounding to two decimal places, making the tokens easier to read and maintain. [1][2]
Component Update:
Updated the DangerZone component to use the new headline "medium" size instead of "large", reflecting the revised typography scale. This will ensure this heading matches the headings on other settings pages.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.97%. Comparing base (5175000) to head (c496022). ⚠️ Report is 4 commits behind head on develop.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates and expands the design token system, focusing on typography and color consistency across the UI. The main changes include introducing new font size tokens, adjusting existing typography scale mappings, and updating color tokens for improved accuracy. These updates ensure more granular and standardized control over typography and color usage throughout the application.
Design Token and Typography Updates:
18and20todesign-tokens.json,tokens.scss, and the JS token mapping, allowing for more granular typography scaling. [1] [2] [3]title,headline, anddisplaysizes) to use the new and adjusted font size values, both indesign-tokens.jsonandtokens.scss, ensuring consistency across the design system. [1] [2]Color Token Adjustments:
accent-sand-subtlestcolor token to use a lighter value (sand-000instead ofsand-100) in both the design tokens JSON and SCSS files, for improved color accuracy and consistency. [1] [2]Token Value Precision:
design-tokens.jsonby rounding to two decimal places, making the tokens easier to read and maintain. [1] [2]Component Update:
DangerZonecomponent to use the newheadline"medium" size instead of "large", reflecting the revised typography scale. This will ensure this heading matches the headings on other settings pages.