Skip to content

feat: FIT-835: Improve customize columns button when Quick View is open #8719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robot-ci-heartex merged 11 commits into from
Oct 29, 2025
Merged

feat: FIT-835: Improve customize columns button when Quick View is open #8719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e27c50f
feat: FIT-835: Improve customize columns button when Quick View is open
ricardoantoniocm Oct 24, 2025
4e7937e
Implements toolbar for QuickView tasks table.
ricardoantoniocm Oct 27, 2025
644bd78
Implements Density toggle for Data Manager. Refactors component.
ricardoantoniocm Oct 27, 2025
f19ef5a
Adds data-testids.
ricardoantoniocm Oct 27, 2025
41dcce6
addressed an issue where the toolbar was nnot behaving as desired
yyassi-heartex Oct 28, 2025
787ba5a
Merge branch 'develop' into 'fb-fit-835'
ricardoantoniocm Oct 29, 2025
504d39a
Fixes inconsistency with isEven logic. Removes double scrollbars.
ricardoantoniocm Oct 29, 2025
b5e258c
Linter fixes.
ricardoantoniocm Oct 29, 2025
c4cef99
Fixes issue with indexes on DM and Quick View.
ricardoantoniocm Oct 29, 2025
df578e2
Disables joyride tours when running cypress tests.
ricardoantoniocm Oct 29, 2025
69a071a
Reorders DM buttons.
ricardoantoniocm Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions web/libs/core/src/lib/Tour/Tour.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,15 @@ export const Tour: React.FC<TourProps> = ({ name, autoStart = false, delay = 0,

const { key, ...joyrideState } = state;

// Disable tours when running in Cypress tests
const isCypressTest = typeof window !== "undefined" && !!(window as any).Cypress;
const shouldRunTour = !isCypressTest && joyrideState.run;

return state.steps.length > 0 ? (
<JoyRide
key={key}
{...joyrideState}
run={shouldRunTour}
{...props}
callback={handleTourCallback}
styles={{
Expand Down
2 changes: 1 addition & 1 deletion web/libs/datamanager/src/components/App/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
content: "";
position: absolute;
height: 4px;
background: linear-gradient(to bottom, var(--black_15), transparent);
background: linear-gradient(to bottom, rgba(var(--color-neutral-shadow-raw) / 20%) 0%, transparent 100%);
}
}

Expand Down
11 changes: 10 additions & 1 deletion web/libs/datamanager/src/components/Common/FieldsButton.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,22 @@ export const FieldsButton = injector(
tooltip,
tooltipTheme = "dark",
openUpwardForShortViewport = true,
"data-testid": dataTestId,
}) => {
const content = [];

if (title) content.push(<React.Fragment key="f-button-title">{title}</React.Fragment>);

const renderButton = () => {
return (
<Button variant="neutral" size="small" look="outlined" leading={icon} trailing={trailingIcon}>
<Button
variant="neutral"
size="small"
look="outlined"
leading={icon}
trailing={trailingIcon}
data-testid={dataTestId}
>
{content.length ? content : null}
</Button>
);
Expand Down Expand Up @@ -112,6 +120,7 @@ export const FieldsButton = injector(
look="outlined"
leading={icon}
trailing={trailingIcon}
data-testid={dataTestId}
>
{content.length ? content : null}
</Button>
Expand Down
Loading
Loading