Skip to content

Conversation

@yyassi-heartex
Copy link
Contributor

This pull request makes several UI improvements to the DataManager filter components, focusing on layout consistency, sizing, and styling for better usability and appearance. The most notable changes involve standardizing input sizes, updating button styles, and ensuring filter components align and scale properly within the sidebar.

before:
Screenshot 2025-10-15 at 12 08 20 PM
Screenshot 2025-10-15 at 12 08 41 PM

after:
Screenshot 2025-10-15 at 12 13 01 PM
Screenshot 2025-10-15 at 1 04 55 PM

Styling and Layout Consistency:

  • Increased the sidebar width for filters in DataManager.scss to provide more space for filter controls.
  • Ensured datepicker and range input elements take full width and have minimum input widths for better alignment and usability in Filters.scss and FilterLine.scss. [1] [2]

Filter Component Updates:

  • Standardized filter input fields by adding a minimum width and setting the input size to "small" in FilterInput.jsx.
  • Updated the filter remove button style to use a string look, small size, and no border for a cleaner appearance in FilterLine.jsx.
  • Refactored the filter operation layout to use BEM-style class names and divs for columns, ensuring consistent alignment and spacing in FilterOperation.jsx. [1] [2] [3]

Range Input Improvements:

  • Wrapped the number range input fields in a flex container with minimum width for better horizontal alignment in Number.jsx.

@yyassi-heartex yyassi-heartex requested a review from a team as a code owner October 15, 2025 17:09
@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit cf60466
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68efd539b469650008e5e0f6
😎 Deploy Preview https://deploy-preview-8650--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit cf60466
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68efd53989e4bc00088593e8
😎 Deploy Preview https://deploy-preview-8650--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit cf60466
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68efd539dfbed70008fa5146
😎 Deploy Preview https://deploy-preview-8650--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the fix label Oct 15, 2025
@yyassi-heartex yyassi-heartex requested review from a team and ricardoantoniocm October 15, 2025 17:09
@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit cf60466
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68efd539d160830008b33f5b
😎 Deploy Preview https://deploy-preview-8650--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.09%. Comparing base (0e9a7f4) to head (cf60466).
⚠️ Report is 2 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (0e9a7f4) and HEAD (cf60466). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0e9a7f4) HEAD (cf60466)
pytests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8650      +/-   ##
===========================================
- Coverage    66.37%   60.09%   -6.29%     
===========================================
  Files          786      548     -238     
  Lines        60312    38773   -21539     
  Branches     10255    10255              
===========================================
- Hits         40033    23300   -16733     
+ Misses       20276    15470    -4806     
  Partials         3        3              
Flag Coverage Δ
lsf-e2e 54.35% <ø> (+2.65%) ⬆️
lsf-integration 50.87% <ø> (-0.05%) ⬇️
lsf-unit 8.59% <ø> (ø)
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robot-ci-heartex robot-ci-heartex merged commit 5f26ee4 into develop Oct 15, 2025
81 of 86 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-808/filters branch October 15, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants