chore: FIT-760: Removing feature flag fflag_fix_all_lsdv_4711_cors_errors_accessing_task_data_short #8597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors_accessing_task_data_short
bmartel
requested review from
a team,
hlomzik and
nick-skriabin
as code owners
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8597 +/- ##
===========================================
- Coverage 67.43% 67.40% -0.03%
===========================================
Files 782 782
Lines 60008 60001 -7
Branches 10161 10154 -7
===========================================
- Hits 40467 40446 -21
- Misses 19538 19552 +14
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/fm sync |
bmartel
commented
Oct 7, 2025
Co-authored-by: Alessio Gozzoli <[email protected]>
Contributor
Author
|
/fm sync |
yyassi-heartex
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the very old FF
fflag_fix_all_lsdv_4711_cors_errors_accessing_task_data_shortas it causes more harm than good by not being on, and is creating more bugs in its wake given it is expected to be on for everyone by this point in time.This pull request removes the feature flag
FF_LSDV_4711and its associated conditional logic throughout the codebase. This flag previously controlled the application of thecrossOrigin: "anonymous"property for media elements to address CORS issues. With this change, thecrossOrigin: "anonymous"property is now always applied, simplifying the logic and ensuring consistent handling of media resources across the application.Feature flag removal and code simplification:
FF_LSDV_4711from feature flag files (feature-flags.ts,feature-flags.js). [1] [2] [3]FF_LSDV_4711and updated media-related default props to always includecrossOrigin: "anonymous"in components such asImageCell.jsx,AnnotationPreview.jsx,MediaPlayer.jsx,Image.jsx,ImageView.jsx,VirtualVideo.tsx,WaveformAudio.ts, andHtxParagraphs.jsx. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]FF_LSDV_4711in media player and audio components, ensuring these behaviors are always active. [1] [2] [3] [4] [5]Image.jsto always default to"anonymous"when not explicitly set, removing the feature flag dependency. [1] [2]These changes ensure consistent cross-origin handling for media elements and simplify the codebase by removing unnecessary feature flag logic.