Skip to content

feat: BROS-496: New Markdown tag to improve layouts #8572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robot-ci-heartex merged 10 commits into from
Oct 4, 2025
Merged

feat: BROS-496: New Markdown tag to improve layouts #8572

robot-ci-heartex merged 10 commits into from
Oct 4, 2025

Conversation

@hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Oct 2, 2025 •
edited
Loading

Example

<View>
  <Markdown>
## Instructions

Please **carefully** read the following text and mark all entities.

- Look for **person names**
- Look for **organization names**  
- Look for **locations**

    
> Remember to be thorough in your analysis!
  </Markdown>
  ...
</View>

TODO

  • Display lists properly, disable style resetting
  • Fix blockquotes (> test), they are broken because > is transformed into &gt;

@hlomzik hlomzik requested a review from nick-skriabin as a code owner October 2, 2025 16:53
@netlify
Copy link

netlify bot commented Oct 2, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit acfc100
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68e055dcacc9b60008b991c6
😎 Deploy Preview https://deploy-preview-8572--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 2, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit acfc100
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68e055dcdfc1fa0008ee96f1

@netlify
Copy link

netlify bot commented Oct 2, 2025 •
edited
Loading

✅ Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit acfc100
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68e055dc02cf070008e656e8
😎 Deploy Preview https://deploy-preview-8572--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the feat label Oct 2, 2025
@hlomzik hlomzik requested review from bmartel and deppp October 2, 2025 16:54
@netlify
Copy link

netlify bot commented Oct 2, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-playground canceled.

Name Link
🔨 Latest commit acfc100
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68e055dc765e2500081c5ee4

@codecov
Copy link

codecov bot commented Oct 2, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 12.19512% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.53%. Comparing base (4487d49) to head (acfc100).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
web/libs/editor/src/tags/visual/Markdown.jsx 12.19% 36 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4487d49) and HEAD (acfc100). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4487d49) HEAD (acfc100)
pytests 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8572      +/-   ##
===========================================
- Coverage    67.43%   60.53%   -6.90%     
===========================================
  Files          780      544     -236     
  Lines        59928    38470   -21458     
  Branches     10154    10161       +7     
===========================================
- Hits         40411    23289   -17122     
+ Misses       19514    15178    -4336     
  Partials         3        3
Flag Coverage Δ
lsf-e2e 54.76% <12.19%> (-0.05%) ⬇️
lsf-integration 51.25% <12.19%> (-0.05%) ⬇️
lsf-unit 8.60% <0.00%> (-0.01%) ⬇️
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hlomzik
Copy link
Collaborator Author

hlomzik commented Oct 3, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/ui/src/assets/icons/support.svg

@robot-ci-heartex robot-ci-heartex merged commit 16b747c into develop Oct 4, 2025
46 of 48 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-bros-496/markdown-tag branch October 4, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmartel bmartel bmartel approved these changes

@nick-skriabin nick-skriabin Awaiting requested review from nick-skriabin nick-skriabin is a code owner

@deppp deppp Awaiting requested review from deppp

@caitlinwheeless caitlinwheeless Awaiting requested review from caitlinwheeless

Assignees

No one assigned

Labels

feat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hlomzik @bmartel @robot-ci-heartex