Skip to content

fix: BROS-495: Import CSV files with semicolon separator #8569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
niklub merged 2 commits into from
Oct 2, 2025
Merged

fix: BROS-495: Import CSV files with semicolon separator #8569

niklub merged 2 commits into from
Oct 2, 2025

Conversation

@niklub
Copy link
Collaborator

@niklub niklub commented Oct 2, 2025

No description provided.

@netlify
Copy link

netlify bot commented Oct 2, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit c271d8f
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68dea635604a8c00080eaac8

@netlify
Copy link

netlify bot commented Oct 2, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-playground canceled.

Name Link
🔨 Latest commit c271d8f
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68dea635fe305d0008aa57e7

@netlify
Copy link

netlify bot commented Oct 2, 2025 •
edited
Loading

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit c271d8f
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68dea635d8be00000834d56f

@github-actions github-actions bot added the fix label Oct 2, 2025
@netlify
Copy link

netlify bot commented Oct 2, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit c271d8f
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68dea6351dd5f0000833c90e

@codecov
Copy link

codecov bot commented Oct 2, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.72%. Comparing base (2f57471) to head (c271d8f).
⚠️ Report is 7 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
label_studio/data_import/models.py 78.26% 5 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop    #8569       +/-   ##
============================================
+ Coverage    66.76%   79.72%   +12.96%     
============================================
  Files          796      237      -559     
  Lines        60701    21484    -39217     
  Branches     10413        0    -10413     
============================================
- Hits         40528    17129    -23399     
+ Misses       20170     4355    -15815     
+ Partials         3        0        -3
Flag Coverage Δ
lsf-e2e ?
lsf-integration ?
lsf-unit ?
pytests 79.72% <78.26%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matt-bernstein
Copy link
Contributor

matt-bernstein commented Oct 2, 2025

If you want to do a second pass when the fix is less urgent, consider trying:

import csv
dialect = csv.Sniffer().sniff(csvfile.readline(), [',',';'])

@niklub
Copy link
Collaborator Author

niklub commented Oct 2, 2025 •
edited by robot-ci-heartex
Loading

/fmt

Workflow run

@niklub niklub merged commit 1ca7ce1 into develop Oct 2, 2025
53 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-bros-495 branch October 2, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmartel bmartel bmartel approved these changes

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@niklub @matt-bernstein @bmartel