Skip to content

fix: FIT-645: Empty Data Manager is displayed when navigating via browser Back button from Settings page #8386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robot-ci-heartex merged 3 commits into from
Sep 10, 2025
Merged

fix: FIT-645: Empty Data Manager is displayed when navigating via browser Back button from Settings page #8386

robot-ci-heartex merged 3 commits into from
Sep 10, 2025

Conversation

@yyassi-heartex
Copy link
Contributor

@yyassi-heartex yyassi-heartex commented Sep 10, 2025

This pull request makes a small improvement to the DataManager class constructor by ensuring that projectId is set even if it is not explicitly provided in the config. If projectId is missing, it will now default to the id property of the project object.

screen-recorder-tue-sep-09-2025-22-37-18.webm
  • In the DataManager constructor (dm-sdk.js), set this.projectId to config.projectId or fall back to config.project.id if not provided.

@yyassi-heartex yyassi-heartex requested a review from a team as a code owner September 10, 2025 02:38
@netlify
Copy link

netlify bot commented Sep 10, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit ef889aa
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68c193a353c9f0000826052b

@netlify
Copy link

netlify bot commented Sep 10, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-playground canceled.

Name Link
🔨 Latest commit ef889aa
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68c193a36d1fe50008b854ef

@netlify
Copy link

netlify bot commented Sep 10, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit ef889aa
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68c193a32a84fa0008fd2a2d

@github-actions github-actions bot added the fix label Sep 10, 2025
@netlify
Copy link

netlify bot commented Sep 10, 2025 •
edited
Loading

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit ef889aa
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68c193a3328723000811fbb1

@codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.58%. Comparing base (e7dbefe) to head (ef889aa).
⚠️ Report is 5 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (e7dbefe) and HEAD (ef889aa). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e7dbefe) HEAD (ef889aa)
pytests 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8386      +/-   ##
===========================================
- Coverage    66.72%   60.58%   -6.14%     
===========================================
  Files          773      543     -230     
  Lines        58189    38249   -19940     
  Branches     10090    10090              
===========================================
- Hits         38828    23175   -15653     
+ Misses       19358    15071    -4287     
  Partials         3        3
Flag Coverage Δ
lsf-e2e 54.70% <ø> (+0.10%) ⬆️
lsf-integration 51.36% <ø> (+<0.01%) ⬆️
lsf-unit 8.62% <ø> (ø)
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Sep 10, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: 53 files changed, 505 insertions(+), 59 deletions(-)

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Sep 10, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: 2 files changed, 4 insertions(+), 4 deletions(-)

@robot-ci-heartex robot-ci-heartex merged commit ddb04d2 into develop Sep 10, 2025
62 of 66 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-645/back-navigation branch September 10, 2025 17:10
yyassi-heartex added a commit that referenced this pull request Sep 10, 2025
@yyassi-heartex
fix: FIT-645: Empty Data Manager is displayed when navigating via bro…
b35aba9 
…wser Back button from Settings page (#8386)

Co-authored-by: yyassi-heartex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmartel bmartel bmartel approved these changes

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yyassi-heartex @bmartel @robot-ci-heartex