chore: BROS-362: Disable smoothing automatically when Bitmask is used #8374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8374 +/- ##
===========================================
- Coverage 67.14% 60.55% -6.60%
===========================================
Files 778 543 -235
Lines 59282 38401 -20881
Branches 10127 10129 +2
===========================================
- Hits 39807 23252 -16555
+ Misses 19472 15146 -4326
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yyassi-heartex
approved these changes
Sep 15, 2025
Contributor
yyassi-heartex
left a comment
yyassi-heartex
left a comment
There was a problem hiding this comment.
Change makes sense, but I noticed that yarn tests were failing. Reran it since it's likely flakey tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the image smoothing logic in the editor by introducing a new computed property,
smoothingEnabled, which dynamically determines whether smoothing should be applied based on the presence of "bitmask" regions. All references to the previoussmoothingproperty in rendering logic and settings initialization have been updated to usesmoothingEnabledinstead, ensuring consistent behavior across the application.Image smoothing logic update:
smoothingEnabledto theImagemodel, which disables smoothing if any annotation region is of type "bitmask"; otherwise, it usesself.smoothingextracted from the tag attributes. (web/libs/editor/src/tags/object/Image/Image.js)Component updates for smoothing logic:
DrawingRegion,ImageLayer, andStageContent) to useitem.smoothingEnabledinstead ofitem.smoothingfor theimageSmoothingEnabledprop and related logic. (web/libs/editor/src/components/ImageView/ImageView.jsx) [1] [2] [3]item.smoothingEnabledinstead ofitem.smoothing. (web/libs/editor/src/components/ImageView/ImageView.jsx)