fix: FIT-139: Fixes Taxonomy dropdown disabled style on Dark Mode #8327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ricardoantoniocm
requested review from
Gondragos,
hlomzik and
nick-skriabin
as code owners
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #8327 +/- ##
===========================================
- Coverage 66.59% 61.49% -5.10%
===========================================
Files 755 538 -217
Lines 55746 37625 -18121
Branches 9924 9924
===========================================
- Hits 37123 23139 -13984
+ Misses 18620 14483 -4137
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yyassi-heartex
approved these changes
Sep 3, 2025
Contributor
|
@ricardoantoniocm worth a look at whitelabel css as well as there might be a chance they were broken there as well. cc: @yyassi-heartex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several style adjustments to improve the appearance and accessibility of disabled multi-select dropdowns in the taxonomy control. The main focus is on ensuring consistent visual cues for disabled states.
Disabled multi-select dropdown styling:
var(--color-neutral-surface)for clearer differentiation.var(--color-neutral-content-subtle)for selection items in disabled multi-selects, making the disabled state more visually apparent.var(--color-neutral-content-subtlest), further reinforcing the disabled state.Screenshots
Before
After