Skip to content

Conversation

@hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Aug 29, 2025

We store conditional per-regions in results even if the condition is not met the moment for better UX, so user can switch between different options and see previous choices for all of them.
But hidden choices won't be submitted.
And they also should not be visible in Info panel to not confuse the user. This fix is dedicated to hide them.

Sample config:

<View>
  <Text name="text" value="$text"/>

  <Labels name="is_correct" toName="text">
    <Label value="correct" background="#CFE1FC"/>
    <Label value="incorrect" background="#C04AC6"/>
  </Labels>

  <View visibleWhen="region-selected" whenLabelValue="incorrect">
    <Header size="4">Why?</Header>
    <Choices name="reason" toName="text"
             perRegion="true" whenLabelValue="incorrect">
      <Choice value="Good reason"/>
      <Choice value="No reason"/>
    </Choices>
  </View>
</View>

with data like {"text":"Any text"}

Before

bros-325-before.mov

After

bros-325-after.mov

We store conditional per-regions in results even if the condition is not met
the moment for better UX, so user can switch between different options and
see previous choices for all of them.
But hidden choices won't be submitted.
And they also should not be visible in Info panel to not confuse the user.
This fix is dedicated to hide them.
@netlify
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 4e52adf
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68b55d0d3a57170008c15e1b
😎 Deploy Preview https://deploy-preview-8301--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 4e52adf
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68b55d0d4728880008658f98
😎 Deploy Preview https://deploy-preview-8301--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 4e52adf
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68b55d0d2bb0c00008052984
😎 Deploy Preview https://deploy-preview-8301--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the fix label Aug 29, 2025
@netlify
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit 4e52adf
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68b55d0d9406d200083b626f
😎 Deploy Preview https://deploy-preview-8301--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.52%. Comparing base (3793dc1) to head (4e52adf).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8301      +/-   ##
===========================================
- Coverage    66.30%   61.52%   -4.79%     
===========================================
  Files          753      536     -217     
  Lines        55689    37591   -18098     
  Branches      9911     9911              
===========================================
- Hits         36926    23128   -13798     
+ Misses       18760    14460    -4300     
  Partials         3        3              
Flag Coverage Δ
lsf-e2e 55.33% <100.00%> (+2.62%) ⬆️
lsf-integration 51.97% <100.00%> (+<0.01%) ⬆️
lsf-unit 8.78% <0.00%> (-0.01%) ⬇️
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hlomzik
Copy link
Collaborator Author

hlomzik commented Sep 1, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/ui/src/assets/icons/inbox.svg

@robot-ci-heartex robot-ci-heartex merged commit 2e76824 into develop Sep 1, 2025
45 of 46 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-bros-325/per-region-info branch September 1, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants