-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: BROS-325: Don't show hidden per-regions in Info panel #8301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We store conditional per-regions in results even if the condition is not met the moment for better UX, so user can switch between different options and see previous choices for all of them. But hidden choices won't be submitted. And they also should not be visible in Info panel to not confuse the user. This fix is dedicated to hide them.
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8301 +/- ##
===========================================
- Coverage 66.30% 61.52% -4.79%
===========================================
Files 753 536 -217
Lines 55689 37591 -18098
Branches 9911 9911
===========================================
- Hits 36926 23128 -13798
+ Misses 18760 14460 -4300
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/git merge
|
We store conditional per-regions in results even if the condition is not met the moment for better UX, so user can switch between different options and see previous choices for all of them.
But hidden choices won't be submitted.
And they also should not be visible in Info panel to not confuse the user. This fix is dedicated to hide them.
Sample config:
with data like
{"text":"Any text"}Before
bros-325-before.mov
After
bros-325-after.mov