fix: BROS-352: Revert order of returned params in useCopyText()
#8238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This order was not supported by all usages.
✅ Deploy Preview for label-studio-playground canceled.
|
✅ Deploy Preview for label-studio-storybook canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
bmartel
approved these changes
Aug 22, 2025
Contributor
bmartel
left a comment
bmartel
left a comment
There was a problem hiding this comment.
Are we sure these are the only affected usages?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8238 +/- ##
===========================================
- Coverage 70.58% 66.52% -4.07%
===========================================
Files 725 509 -216
Lines 52670 34612 -18058
Branches 9015 9015
===========================================
- Hits 37179 23024 -14155
+ Misses 15488 11585 -3903
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I checked the other usages, this will work. We need to address the inconsistent usage of this, tuples should always be [state, setState] when creating hooks like this. |
Contributor
|
/git merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This order was not supported by all usages.