Skip to content

Conversation

@ricardoantoniocm
Copy link
Contributor

@ricardoantoniocm ricardoantoniocm commented Aug 14, 2025

This PR was automatically generated via Follow Merge. Workflow Run
Please ensure that all linked upstream Pull Requests are merged before proceeding with this one.

Reason for change

When uploading files manually the transition between the uploading state and the uploaded state is not smooth. The empty state is shown briefly.

This PR addresses that issue and includes improvements for the layout, and animations to highlight recently uploaded files.

This also implements truncation for the file names so that they don't extend beyond a single line, ensuring a natural visual flow of each file upload.

In addition to the above, the file size of uploaded files is now shown (does not work currently on LSE).

Before

https://www.loom.com/share/f264a81ad8b74a8e9f780fc745c8b597?sid=c4c469fe-6a3e-436f-9841-04f27d84b9a1

After

https://www.loom.com/share/0eef61547f304c1ebe89164b4a72eb51?sid=2bb3de0a-6a06-47cb-bb95-d6355447f49d

… order of uploaded files to prevent visual glitches and adds animation to highlight recently uploaded files. Implements helper to format file size. Fixed the issue that file sizes weren't being displayed.
@netlify
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 8cdc7be
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68a5bcfb34c95f0008763993

@netlify
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for label-studio-playground canceled.

Name Link
🔨 Latest commit 8cdc7be
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68a5bcfbb45fe70008b09ace

@netlify
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 8cdc7be
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68a5bcfbe89afa00090693f6

@netlify
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit 8cdc7be
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68a5bcfbf5ddc7000867c98c

@github-actions github-actions bot added the fix label Aug 14, 2025
@ricardoantoniocm ricardoantoniocm self-assigned this Aug 14, 2025
@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.45%. Comparing base (79494e7) to head (8cdc7be).
⚠️ Report is 1 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
web/libs/core/src/lib/utils/helpers.ts 16.66% 5 Missing ⚠️
label_studio/data_import/serializers.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8155      +/-   ##
===========================================
+ Coverage    69.25%   70.45%   +1.20%     
===========================================
  Files          721      721              
  Lines        52235    52247      +12     
  Branches      8837     8838       +1     
===========================================
+ Hits         36175    36813     +638     
+ Misses       16057    15431     -626     
  Partials         3        3              
Flag Coverage Δ
lsf-e2e 59.72% <16.66%> (+3.14%) ⬆️
lsf-integration 55.53% <16.66%> (-0.02%) ⬇️
lsf-unit 9.43% <ø> (ø)
pytests 78.37% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardoantoniocm ricardoantoniocm marked this pull request as ready for review August 14, 2025 03:52
@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented Aug 15, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/editor/tests/integration/e2e/control_tags/text-with-dual-taxonomy.cy.ts

@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented Aug 20, 2025

/git merge

Workflow run
Successfully merged:

@robot-ci-heartex robot-ci-heartex merged commit 3a6cd89 into develop Aug 20, 2025
77 of 80 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-531/import-step-flickers-when-switching-uploading-completed-state branch August 20, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants