-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: FIT-531: Fix flickering when switching from uploading to uploaded on Import modal #8155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: FIT-531: Fix flickering when switching from uploading to uploaded on Import modal #8155
Conversation
… order of uploaded files to prevent visual glitches and adds animation to highlight recently uploaded files. Implements helper to format file size. Fixed the issue that file sizes weren't being displayed.
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8155 +/- ##
===========================================
+ Coverage 69.25% 70.45% +1.20%
===========================================
Files 721 721
Lines 52235 52247 +12
Branches 8837 8838 +1
===========================================
+ Hits 36175 36813 +638
+ Misses 16057 15431 -626
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/git merge
|
Co-authored-by: Jo Booth <[email protected]>
…g-completed-state' of https://github.com/heartexlabs/label-studio into fb-fit-531/import-step-flickers-when-switching-uploading-completed-state
…g-completed-state' of github.com:heartexlabs/label-studio into fb-fit-531/import-step-flickers-when-switching-uploading-completed-state
|
/git merge
|
This PR was automatically generated via Follow Merge. Workflow Run
Please ensure that all linked upstream Pull Requests are merged before proceeding with this one.
Reason for change
When uploading files manually the transition between the uploading state and the uploaded state is not smooth. The empty state is shown briefly.
This PR addresses that issue and includes improvements for the layout, and animations to highlight recently uploaded files.
This also implements truncation for the file names so that they don't extend beyond a single line, ensuring a natural visual flow of each file upload.
In addition to the above, the file size of uploaded files is now shown (does not work currently on LSE).
Before
https://www.loom.com/share/f264a81ad8b74a8e9f780fc745c8b597?sid=c4c469fe-6a3e-436f-9841-04f27d84b9a1
After
https://www.loom.com/share/0eef61547f304c1ebe89164b4a72eb51?sid=2bb3de0a-6a06-47cb-bb95-d6355447f49d