fix: FIT-490: Focus is lost in Headers input fields after key is entered #8077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red at Webhooks page
…sts button styles and alignment.
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ricardoantoniocm
changed the title
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
ricardoantoniocm
requested review from
bmartel,
nick-skriabin and
yyassi-heartex
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8077 +/- ##
===========================================
- Coverage 70.51% 66.16% -4.35%
===========================================
Files 719 505 -214
Lines 51365 33842 -17523
Branches 8733 8733
===========================================
- Hits 36218 22393 -13825
+ Misses 15144 11446 -3698
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hlomzik
reviewed
Aug 1, 2025
| Delete Webhook | ||
| </Button> | ||
| )} | ||
| {webhook === null && <div />} |
Collaborator
There was a problem hiding this comment.
This empty div can be moved to previous condition
Contributor
Author
There was a problem hiding this comment.
Thank you! Latest commit addresses this.
hlomzik
approved these changes
Aug 4, 2025
Collaborator
hlomzik
left a comment
hlomzik
left a comment
There was a problem hiding this comment.
I'd suggest intensive testing, but approach is good.
Buttons duplication seems a little excess but it's a small portion and we need a little different layout, all good!
Collaborator
|
/git merge
|
…ds-after-key-entered-webhooks-page' Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/16724149349
robot-ci-heartex
deleted the
fb-fit-490/focus-lost-headers-input-fields-after-key-entered-webhooks-page
branch
hlomzik
added a commit
that referenced
this pull request
Aug 5, 2025
…red (#8077) Co-authored-by: hlomzik <[email protected]>
yyassi-heartex
pushed a commit
that referenced
this pull request
Aug 5, 2025
…red (#8077) (#8090) Co-authored-by: Ricardo Cabral <[email protected]> Co-authored-by: hlomzik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression that caused the focus to be lost after entering a single character on the header fields.
This field also adjusts button alignment and styles.
After
https://www.loom.com/share/f72e6326cfb94c948f8a8fc6ab942b8f?sid=75a2932e-fe16-42ef-a05a-887c5a1af267