fix: FIT-407: buttonVariant font size cleanup #8009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bmartel
approved these changes
Jul 18, 2025
Contributor
bmartel
left a comment
bmartel
left a comment
There was a problem hiding this comment.
This has global implications, I am fairly certain this is the most correct base state of a button, just want to be sure this doesn't have any weird effects in the application.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8009 +/- ##
============================================
+ Coverage 35.04% 55.02% +19.98%
============================================
Files 657 465 -192
Lines 45376 32084 -13292
Branches 7566 8368 +802
============================================
+ Hits 15901 17655 +1754
+ Misses 29472 14429 -15043
+ Partials 3 0 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a minor update to the
buttonVariantfunction inweb/libs/ui/src/lib/button/button.tsx. The change removes thetext-label-mediumclass from the button styles to simplify the applied text styles.before:
after:
web/libs/ui/src/lib/button/button.tsx: Removed thetext-label-mediumclass from the button's style definitions in thebuttonVariantfunction. This simplifies the text styling by relying on other existing classes.