feat: BROS-189: Add default open state to Collapse #7993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7993 +/- ##
===========================================
+ Coverage 63.68% 65.89% +2.21%
===========================================
Files 715 504 -211
Lines 50292 33382 -16910
Branches 8589 8797 +208
===========================================
- Hits 32027 21998 -10029
+ Misses 18262 11381 -6881
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
/fmt |
hlomzik
reviewed
Jul 17, 2025
| _value: types.optional(types.string, ""), | ||
| value: types.optional(types.string, ""), | ||
|
|
||
| open: types.optional(types.boolean, false), |
Collaborator
There was a problem hiding this comment.
This param should be optional and nullable then to allow global open to work
hlomzik
reviewed
Jul 18, 2025
Co-authored-by: Andrew <[email protected]>
Member
Author
|
/fmt |
Member
Author
|
/fm merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
openproperty to theCollapsecomponent, enabling the default collapsed state to be set for individual panels. The changes span documentation updates, model adjustments, and rendering logic enhancements.Documentation Updates:
openproperty to theCollapsecomponent's documentation, specifying its type asbooleanand default value asfalse. This property sets the default collapsed state. (docs/source/includes/tags/collapse.md, docs/source/includes/tags/collapse.mdR7)Model Enhancements:
PanelModelandModelinCollapse.jsxto include theopenproperty as an optional boolean with a default value offalse. (web/libs/editor/src/tags/visual/Collapse.jsx, [1] [2]Rendering Logic Improvements:
HtxCollapsecomponent to calculatedefaultActiveKeysbased on theopenproperty of child panels, ensuring the default collapsed state is respected during rendering. (web/libs/editor/src/tags/visual/Collapse.jsx, web/libs/editor/src/tags/visual/Collapse.jsxR129-R140)