fix: FIT-132: Date picker filter dropdown in data manager not optimized for dark mode #7990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptimized for Dark mode
…are overriden in prod given react-datepicker styles are loaded async.
…into fb-fit-132/date-picker-filter-dropdown-data-manager-not-optimized-dark-mode
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7990 +/- ##
===========================================
- Coverage 69.37% 65.58% -3.79%
===========================================
Files 712 502 -210
Lines 50013 33228 -16785
Branches 8558 8558
===========================================
- Hits 34697 21794 -12903
+ Misses 15313 11431 -3882
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ricardoantoniocm
changed the title
yyassi-heartex
approved these changes
Jul 16, 2025
ricardoantoniocm
changed the title
Contributor
Author
|
/git merge
|
…ata-manager-not-optimized-dark-mode' Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/16349287722
robot-ci-heartex
deleted the
fb-fit-132/date-picker-filter-dropdown-data-manager-not-optimized-dark-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces react-datepicker style overrides using specificity given the CSS file for this component is loaded async.
It also adjusts the height of the time picker container so that it spans the height of the datepicker popover.
Note: Scrollbar styles to be fixed separately.
Before
After