fix: UTC-168: Conditional Nesting Issue - Text Area #7982
Conversation
nass600
requested review from
Gondragos,
hlomzik and
nick-skriabin
as code owners
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-playground canceled.
|
✅ Deploy Preview for label-studio-storybook canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7982 +/- ##
===========================================
- Coverage 69.49% 64.90% -4.60%
===========================================
Files 712 503 -209
Lines 50159 33381 -16778
Branches 8583 8583
===========================================
- Hits 34860 21667 -13193
+ Misses 15296 11711 -3585
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/git merge
|
|
/git merge
|
There was a problem hiding this comment.
I see that TextArea just doesn't use VisibilityMixin. I think that might be a proper fix. Can you try it?
This mixin already checks for parent's visibility
There was a problem hiding this comment.
Hmmm, but your solution would work for all classification controls. Also I was concerned about check for required controls, which uses visibility params. But I checked and it actually works well, so the only thing to fix is serialization. And your solution covers it well! Approving.
|
/git merge
|
Fixed submitting annotations that should not due to its parent visibility
Before:
conditional-choices-submit-before.mov
After:
conditional-choices-submit-after.mov