fix: FIT-380: Remove the default zoom calculation for Audio rendering and render full waveform #7980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and render full waveform
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7980 +/- ##
===========================================
+ Coverage 62.62% 64.90% +2.28%
===========================================
Files 712 503 -209
Lines 50166 33381 -16785
Branches 8585 8583 -2
===========================================
- Hits 31414 21667 -9747
+ Misses 18749 11711 -7038
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cloudmark
approved these changes
Jul 15, 2025
Contributor
|
Tested it as well on my branch (on a big file and it works well) |
Contributor
Author
|
/git merge
|
Contributor
Author
|
/fm merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
setInitialZoommethod and its associated call from theVisualizerclass inVisualizer.ts. These changes simplify the initialization process by eliminating the logic for setting an initial zoom level based on a fixed duration.Simplification of initialization logic:
Visualizer.ts: Removed thesetInitialZoommethod, which calculated and set an initial zoom level to display 10 seconds of audio data. This includes the removal of the feature flag check (isFF(FF_AUDIO_SPECTROGRAMS)) and its associated logic.Visualizer.ts: Removed the call tosetInitialZoomin the constructor, streamlining the initialization process.