fix: FIT-317: User can add polygon points to unfinished Polygon in Compare all annotations mode #7900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpare all annotations mode
yyassi-heartex
requested review from
Gondragos,
hlomzik and
nick-skriabin
as code owners
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7900 +/- ##
===========================================
- Coverage 65.53% 59.04% -6.50%
===========================================
Files 682 475 -207
Lines 49574 33023 -16551
Branches 8596 8597 +1
===========================================
- Hits 32490 19499 -12991
+ Misses 17084 13524 -3560
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hlomzik
approved these changes
Jul 2, 2025
Contributor
Author
|
/git merge
|
nick-skriabin
approved these changes
Jul 3, 2025
yyassi-heartex
added a commit
that referenced
this pull request
Jul 4, 2025
…mpare all annotations mode (#7900) Co-authored-by: yyassi-heartex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the
DrawingToolmixin in theweb/libs/editor/src/mixins/DrawingTool.jsfile to check feature flag (FF_DEV_3391) and update the behavior of theisAllowedInteractionmethod based on this flag.issue occurs with FF
fflag_fix_front_dev_3391_interactive_view_allswitched onPolygon.Compare.all.-.30.06.2025.mp4
after fix - Compare all view will act as read only
Feature flag integration:
web/libs/editor/src/mixins/DrawingTool.js: AddedFF_DEV_3391to the feature flags import list to enable conditional logic for the new feature.Behavior update:
web/libs/editor/src/mixins/DrawingTool.js: Updated theisAllowedInteractionmethod to returnfalseif theFF_DEV_3391flag is enabled and the annotation is not editable, ensuring stricter control over interactions when the flag is active.