fix: FIT-306: Zooming out the page breaks audio rendering of the waveform #7854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
yyassi-heartex
approved these changes
Jun 26, 2025
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bmartel
added a commit
that referenced
this pull request
Jun 26, 2025
bmartel
added a commit
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to improve the handling of
pixelRatioin theLayerandVisualizerclasses by makingpixelRatioaccessible outside theLayerclass and ensuring it is updated consistently across all layers.Changes to
pixelRatiohandling:web/libs/editor/src/lib/AudioUltra/Visual/Layer.ts: Changed the visibility of thepixelRatioproperty in theLayerclass fromprivatetopublic, allowing it to be accessed and modified externally.web/libs/editor/src/lib/AudioUltra/Visual/Visualizer.ts: Updated theVisualizerclass to set thepixelRatioproperty for both the main layer and other layers during the dimension update process, ensuring consistency across all layers.