fix: BROS-87: Introduce unified zoom behavior for trackpads and mice #7852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bmartel
approved these changes
Jun 26, 2025
nass600
approved these changes
Jun 26, 2025
nick-skriabin
changed the title
Member
Author
|
/fmt |
yyassi-heartex
approved these changes
Jun 26, 2025
Contributor
yyassi-heartex
left a comment
yyassi-heartex
left a comment
There was a problem hiding this comment.
minor suggestion but other wise looks good
hlomzik
reviewed
Jun 26, 2025
|
|
||
| // Limit the maximum zoom change per event to prevent aggressive zooming | ||
| // This prevents users from accidentally zooming too far with a single wheel event | ||
| const limitedZoomChange = Math.max( |
Collaborator
There was a problem hiding this comment.
you need to use clamp() here because you don't limit minimum value
Collaborator
There was a problem hiding this comment.
basically you just need to run it two times, with ±MAX_CHANGE and with MIN/MAX
hlomzik
requested changes
Jun 26, 2025
Collaborator
hlomzik
left a comment
hlomzik
left a comment
There was a problem hiding this comment.
one important change regarding the goal of the PR, and the rest is good
Member
Author
|
/fmt |
hlomzik
approved these changes
Jun 26, 2025
nass600
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just moving the functionality under a feature flag.
Reason: buggy behavior.