Skip to content

fix: FIT-268: [FE] 'Reviewer: contains' filter disappears from the tab when reviewer customize columns #7843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robot-ci-heartex merged 7 commits into from
Jun 27, 2025
Merged

fix: FIT-268: [FE] 'Reviewer: contains' filter disappears from the tab when reviewer customize columns #7843

robot-ci-heartex merged 7 commits into from
Jun 27, 2025

Conversation

@yyassi-heartex
Copy link
Contributor

@yyassi-heartex yyassi-heartex commented Jun 25, 2025

This pull request introduces support for a disabled property across various components in the web/libs/datamanager directory. The changes ensure that UI elements respect the disabled state, preventing user interaction when necessary. Additionally, styling updates have been made to visually indicate the disabled state.

Enhancements to support disabled property:

Updates to components:

  • FieldsButton.Checkbox and Menu.Item: Added support for the disabled property to prevent interaction with disabled fields. ([[1]](https://github.com/HumanSignal/label-studio/pull/7843/files#diff-3fb0e2e098745a1222ce831ce64d830edaa076fdfa324030ad6ff9502a754caaR17-R23), [[2]](https://github.com/HumanSignal/label-studio/pull/7843/files#diff-3fb0e2e098745a1222ce831ce64d830edaa076fdfa324030ad6ff9502a754caaL121-R131))
  • FilterLine and FilterOperation: Integrated the disabled property into filters and operations, ensuring consistent behavior across filter-related components. ([[1]](https://github.com/HumanSignal/label-studio/pull/7843/files#diff-a98c30edd14e072861efd8594e7a3bafca80465568f20aa4c628e0d98f4bd756R70-R81), [[2]](https://github.com/HumanSignal/label-studio/pull/7843/files#diff-a98c30edd14e072861efd8594e7a3bafca80465568f20aa4c628e0d98f4bd756R92), [[3]](https://github.com/HumanSignal/label-studio/pull/7843/files#diff-d7e5a75e95cec2dc137241ef7d46e9704f882c4f21ae229ad1ca3666aa84eb5dL20-R20), [[4]](https://github.com/HumanSignal/label-studio/pull/7843/files#diff-d7e5a75e95cec2dc137241ef7d46e9704f882c4f21ae229ad1ca3666aa84eb5dL81-R81), [[5]](https://github.com/HumanSignal/label-studio/pull/7843/files#diff-d7e5a75e95cec2dc137241ef7d46e9704f882c4f21ae229ad1ca3666aa84eb5dR95))

Updates to filter types:

  • BooleanFilter and Common: Added disabled support to filter input components for boolean and common types. ([[1]](https://github.com/HumanSignal/label-studio/pull/7843/files#diff-e7b7e7c79aec0abb02b629c79b59f86e82b88ff2e0903b2eb2d04e0ef74afabfR16), [[2]](https://github.com/HumanSignal/label-studio/pull/7843/files#diff-c900d5710eb541f15247f75d940beb37d2404227d2039b330ddf30ffd448812aR15))
  • VariantSelect in List: Enhanced the VariantSelect component to respect the disabled property. ([[1]](https://github.com/HumanSignal/label-studio/pull/7843/files#diff-a0ca81dca8c1f711a923db92ff91f83a7a6ddf736feeeaa5eaac67b2c651e9f8L10-R10), [[2]](https://github.com/HumanSignal/label-studio/pull/7843/files#diff-a0ca81dca8c1f711a923db92ff91f83a7a6ddf736feeeaa5eaac67b2c651e9f8R38))

Styling improvements for disabled elements:

  • Menu.scss: Updated styles to visually indicate disabled state, including changes to hover behavior, cursor style, and opacity for disabled menu items. ([web/libs/datamanager/src/components/Common/Menu/Menu.scssR36-R51](https://github.com/HumanSignal/label-studio/pull/7843/files#diff-e57dff1c992a13a36fea76e4443fb7e4a267e8bf52c98f01e31ea1d44f690d5bR36-R51))

Model updates:

  • TabColumn in tab_column.jsx: Introduced a disabled property to model definitions, ensuring the disabled state is accounted for in data logic and visibility checks. ([web/libs/datamanager/src/stores/Tabs/tab_column.jsxR78-R85](https://github.com/HumanSignal/label-studio/pull/7843/files#diff-8af86387dbeb89c542f4b596a106edfff88dc5a320b2a13950bb928a8cf585ebR78-R85))

@yyassi-heartex yyassi-heartex requested a review from a team as a code owner June 25, 2025 21:55
@netlify
Copy link

netlify bot commented Jun 25, 2025 •
edited
Loading

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit fea0f81
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/685eb96835df3c000819b462

@netlify
Copy link

netlify bot commented Jun 25, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit fea0f81
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/685eb9689ce1230008e13061
😎 Deploy Preview https://deploy-preview-7843--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jun 25, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit fea0f81
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/685eb968bd5a3c0008ccbd9a

@github-actions github-actions bot added the fix label Jun 25, 2025
@yyassi-heartex yyassi-heartex requested review from a team and removed request for a team June 25, 2025 21:55
@netlify
Copy link

netlify bot commented Jun 25, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit fea0f81
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/685eb968baef5a0008d13cb4
😎 Deploy Preview https://deploy-preview-7843--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

bmartel
bmartel approved these changes Jun 25, 2025
View reviewed changes
@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Jun 26, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: 1 file changed, 3 insertions(+), 2 deletions(-)

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Jun 26, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/frontend-test/src/helpers/utils/SVGTransformUtils.ts

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Jun 26, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: create mode 100644 label_studio/data_manager/tests/migrations/test_cleanup_inconsistent_filtergroup.py

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Jun 27, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: 5 files changed, 89 insertions(+), 21 deletions(-)

@hlomzik
Copy link
Collaborator

hlomzik commented Jun 27, 2025

How does this change to disabled solve the original issue with filter? Could you maybe attach some screenshots or video?

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Jun 27, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: delete mode 100644 web/libs/ui/src/typography/sub.tsx

@robot-ci-heartex robot-ci-heartex merged commit f59ca4c into develop Jun 27, 2025
44 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-268/filter-columns branch June 27, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmartel bmartel bmartel approved these changes

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yyassi-heartex @hlomzik @bmartel @robot-ci-heartex