-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: FIT-221: fix Toggle behavior when parent driven #7734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
nass600
approved these changes
Jun 11, 2025
Contributor
Author
|
/git merge
|
Contributor
Author
|
/git merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
Togglecomponent inweb/libs/ui/src/lib/toggle/toggle.tsxto improve performance and maintainability by introducing theuseCallbackhook for theonChangehandler. The most important changes are summarized below:Ultimatly this allows us to undo a toggle from the parent if needed
Performance Improvement:
useCallbackforonChangehandler: Added a memoizedonChangeHandlerfunction usinguseCallbackto optimize re-renders and ensure consistent function references.Code Simplification:
onChangelogic withonChangeHandler: Updated theonChangeprop of the input element to use the newonChangeHandlerfunction, replacing the previous inline logic.Dependency Updates:
useCallback: AddeduseCallbackto the list of imported hooks from React.