Skip to content

Conversation

@ricardoantoniocm
Copy link
Contributor

@ricardoantoniocm ricardoantoniocm commented Jun 5, 2025

Reason for change

This pull request aims to enhance the "Data Import" page by updating its text and layout. The primary goals are to improve user experience, provide clearer guidance on file formats and import processes, and expand support for various data types.

Key changes include:

  • Layout changes:
    • Make sure the drag and drop area is centered & large regardless of FFs
    • Create a Tips section, move the footer text there
  • Text:
    • Added support for JSONL and Parquet (highlighting LSE-only for Parquet).
    • Refined and reordered the audio, video, image, and data categories for better clarity (e.g., Images listed before Text).
    • Changed "timeSeries" to "structuredData" for consistent terminology.
    • Improved style of error when upload fails.

Screenshots

Before:
FF OFF
image

FF ON
image

After:
FF OFF
image
https://www.loom.com/share/e9f01bee217940159353b5ce1e54462c?sid=fe42051d-cd1c-4258-ba27-2fd2ca561f5e

FF ON
image
image
https://www.loom.com/share/b41db3943a324b44a2d5a4847b1aaf2a?sid=e1409d5d-4c92-436e-ac65-0335fd9e7944

Reviewer notes

  • Please review the changes in web/apps/labelstudio/src/pages/CreateProject/Import/Import.jsx which include UI updates, refactoring of the input preview, and consolidation of footer content.
  • Pay attention to the updated terminology (e.g., "structuredData").
  • Verify that the UI changes correctly address the points raised in the "Acceptance Criteria," such as:
    • Alignment of elements (e.g., JSON preview).
    • Clarity and placement of text for file formats (especially video, JSONL, Parquet) and cloud storage.
    • Responsiveness and intuitive interaction with the page.
    • The behavior and extent of the file drop zone.
  • The goal was to improve user guidance and streamline the import process. Feedback on the clarity and effectiveness of these changes is appreciated.

@netlify
Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 79e3b52
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/684acb2990b7cb0008ffe783

@netlify
Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 79e3b52
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/684acb2942851d000847fefd
😎 Deploy Preview https://deploy-preview-7704--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 79e3b52
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/684acb29995ccc00081f454d

@ricardoantoniocm ricardoantoniocm self-assigned this Jun 5, 2025
@netlify
Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit 51e3fcd
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/6849dfff3ffafa00081e66ff
😎 Deploy Preview https://deploy-preview-7704--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the feat label Jun 5, 2025
@ricardoantoniocm ricardoantoniocm requested a review from Copilot June 9, 2025 21:56

This comment was marked as outdated.

@ricardoantoniocm ricardoantoniocm requested a review from Copilot June 11, 2025 20:43

This comment was marked as outdated.

@ricardoantoniocm ricardoantoniocm marked this pull request as ready for review June 11, 2025 20:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Data Import page by updating texts, layouts, and UI components to improve user guidance on file formats and the import process.

  • Updated styling for error messages and dropzone with improved spacing, transitions, and visual emphasis.
  • Revised supported file types and reorganized file format information, including updated tooltips for video formats.
  • Refactored components including removal of the legacy footer and updates to the JSON input preview.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
web/apps/labelstudio/src/pages/CreateProject/Import/Import.scss Updated SCSS styling for error messaging, dropzone layout, and file status.
web/apps/labelstudio/src/pages/CreateProject/Import/Import.jsx UI refactoring, updated supported file extensions, and improved tooltip and JSON preview behavior.
Comments suppressed due to low confidence (1)

web/apps/labelstudio/src/pages/CreateProject/Import/Import.scss:205

  • [nitpick] Verify that the asymmetric inset values align with the intended design across different screen sizes; consider using consistent spacing variables if possible.
      inset: 16px 48px 48px;

@ricardoantoniocm ricardoantoniocm requested a review from nass600 June 12, 2025 10:54
@ricardoantoniocm ricardoantoniocm merged commit 5c4fb9b into develop Jun 12, 2025
62 of 64 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-207/fix-text-layout-data-import-page branch June 12, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants