fix: FIT-133: Locked region can be edited on Timeline #7622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyassi-heartex
requested review from
a team,
Gondragos,
hlomzik and
nick-skriabin
as code owners
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
This has actually nothing to do with templates, it's a bug in Timeline Regions visualization, let's rename PR and ticket. Given we actually actively fix templates right now that can make a confusion. |
hlomzik
approved these changes
May 26, 2025
yyassi-heartex
changed the title
yyassi-heartex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a "locked" property to timeline regions and integrates it across various components to ensure locked regions are visually and functionally distinct. The changes primarily focus on preventing interactions with locked regions and updating the UI accordingly.
locked timeline regions will not be allowed to resize. when locked the draggable handles will be made invisible
Core Functionality Updates:
lockedproperty to theTimelineRegioninterface and related data structures, allowing regions to be marked as locked. (web/libs/editor/src/components/Timeline/Types.ts- [1]web/libs/editor/src/components/Timeline/Views/Frames/Utils.ts- [2] [3]setRangemethod inTimelineRegionto prevent modifications to locked regions. (web/libs/editor/src/regions/TimelineRegion.js- web/libs/editor/src/regions/TimelineRegion.jsR115)UI Enhancements:
Keypointscomponent to pass thelockedproperty and visually differentiate locked points using a new_lockedCSS modifier. (web/libs/editor/src/components/Timeline/Views/Frames/Keypoints.tsx- [1] [2] [3] [4] [5];web/libs/editor/src/components/Timeline/Views/Frames/Keypoints.scss- [6]Framescomponent to disable cursor interactions for locked regions. (web/libs/editor/src/components/Timeline/Views/Frames/Frames.tsx- web/libs/editor/src/components/Timeline/Views/Frames/Frames.tsxL180-R180)Data Flow Adjustments:
lockedproperty is propagated through the data tree and passed to components such asKeypointsandMinimap. (web/libs/editor/src/components/SidePanels/OutlinerPanel/OutlinerTree.tsx- [1]web/libs/editor/src/components/Timeline/Views/Frames/Minimap.tsx- [2]web/libs/editor/src/tags/object/Video/HtxVideo.jsx- [3]