fix: OPTIC-2145: Audio tracker line is not visible in dark mode #7514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoantoniocm
requested review from
Gondragos,
hlomzik and
nick-skriabin
as code owners
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the audio tracker line was not visible in Dark Mode by switching from a hardcoded RGBA value to a theme-aware CSS variable.
- Updated the color assignment for the audio tracker line in Cursor.ts
- Ensured compatibility with both Light and Dark Mode themes by using the CSS variable "var(--color-neutral-border)"
Comments suppressed due to low confidence (1)
web/libs/editor/src/lib/AudioUltra/Cursor/Cursor.ts:61
- Ensure that the CSS variable 'var(--color-neutral-border)' delivers sufficient contrast in both Light and Dark Mode themes by cross-checking with the current design tokens or accessibility guidelines.
color = "var(--color-neutral-border)";
bmartel
approved these changes
May 12, 2025
robot-ci-heartex
deleted the
fb-optic-2145/audio-tracker-line-is-not-visible-in-dark-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
The audio tracker line in the Quick View is not visible when Dark Mode is enabled, making it difficult for users to navigate the audio data. This change updates the color of the tracker line to use a theme-aware variable, ensuring it is visible in both Light and Dark Modes.
Screenshots
Before:
After:
Rollout strategy
This is a small visual change and does not require a specific rollout strategy.
Testing
Risks
There are no anticipated risks associated with this minor visual correction.
Reviewer notes
Please verify that the color variable
var(--color-neutral-border)ensures sufficient contrast for the audio tracker line to be visible in both Light and Dark Mode themes.General notes
The fix involves changing a hardcoded color value to a CSS variable that adapts to the current theme.