feat: LEAP-1924: Allow to edit Timeline span by drag-n-drop #7251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smooth intuitive interaction to easily edit spans on timeline. The biggest effort here was to fix undo/redo stack to keep UX convenient and predictable. Only one item in history is created with final state for these actions: - new region is drawn - existing region was edited by drag-n-drop - existing region was edited in info panel: - in input and the focus was moved away - in input by clicking on up/down arrows
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Gondragos
reviewed
Mar 19, 2025
Gondragos
approved these changes
Mar 19, 2025
Too many changes for such a small thing, but it improves UX
Contributor
|
/fm sync |
Gondragos
approved these changes
Mar 20, 2025
Contributor
|
/fm sync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows smooth intuitive interaction to easily edit spans on timeline.
The biggest effort here was to fix undo/redo stack to keep UX convenient and predictable. Only one item in history is created with final state for these actions:
Video#startDrawing(),Video#finishDrawing()andTimelineRegion#setRange()(former less correctsetRanges()) were edited to acceptmodeto distinguish actions needed andregionto find current region to edit it instead of creating a new one.The main entry point is still
Timeline/Views/Frames#onFrameScrub()— now extended to handle drawing new region, editing existing region and updating current position in a Video tag.