fix: OPTIC-1785: Validate S3 bucket name on storage connection form #7183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating bucket name in serializer
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7183 +/- ##
===========================================
- Coverage 77.32% 77.31% -0.02%
===========================================
Files 188 188
Lines 14581 14586 +5
===========================================
+ Hits 11275 11277 +2
- Misses 3306 3309 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcanu
requested review from
a team,
bmartel and
wesleylima
and removed request for
wesleylima
Contributor
Author
|
/fm sync |
wesleylima
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a mixin class to handle common functionality for S3 storage serializers and refactors existing serializers to use this mixin. The most important changes include the creation of the
S3StorageSerializerMixin, the addition of a bucket name validation method, and the refactoring ofS3ImportStorageSerializerandS3ExportStorageSerializerto use the new mixin.Refactoring and code reuse:
S3StorageSerializerMixinto encapsulate common functionality for S3 storage serializers, including secure field handling and bucket name validation.S3ImportStorageSerializerto inherit fromS3StorageSerializerMixinandImportStorageSerializer, consolidating common code and adding thepresignfield.S3ExportStorageSerializerto inherit fromS3StorageSerializerMixinandExportStorageSerializer, consolidating common code.Validation improvements:
validate_bucketmethod toS3StorageSerializerMixinto validate the bucket name usingvalidate_bucket_namefrombotocore.handlers.Code simplification:
S3ImportStorageSerializer.secure_fieldswithself.secure_fieldsto simplify code and improve maintainability.Screen.Recording.2025-03-07.at.14.34.33.mov