feat: LEAP-1893: LEAP-1900: Add setting to toggle region looping and autoplay #7166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default value is changed to false to not annoy users. In order to do so AudioUltra view was changed to move provider with settings higher.
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
hlomzik
changed the title
Previously if it was after the region or just at the end of it, the cursor was moved to the end of the region, which stops playing if looping is disabled. Now it's always moved to the beginning of the region.
- uniform font size for all controls - increase modal width to fit new settings - adjust paddings for better apearance - use our common tooltips for info icon
- proper ref typing - fix issues - remove font-size from a wrong place - it was overriding sizing params
hlomzik
changed the title
Collaborator
Author
|
/git merge
|
Hook is moved from LSE to core lib.
…nSignal/label-studio into fb-leap-1893/audio-regions-settings
Collaborator
Author
|
/git merge
|
Gondragos
reviewed
Mar 10, 2025
Contributor
|
Excellent improvements! And it's great that the hook has been moved to the core library, and now with tests. This was all sorely lacking. I only have doubts about one setting, which is now also persistent, but perhaps that was unnecessary for it. |
Gondragos
approved these changes
Mar 10, 2025
Contributor
|
/git merge
|
Contributor
|
/fm sync |
Member
|
/fm sync |
…nSignal/label-studio into fb-leap-1893/audio-regions-settings
Collaborator
Author
|
/git merge
|
nass600
approved these changes
Mar 11, 2025
Contributor
|
/git merge
|
Contributor
|
/fm sync |
It happens in a lot of cases, because playhead could be moved to the end of the region and in this case `updateLoop()` pauses the audio if looping is disabled. So we have to explicitly update the current time to the start of the region.
Gondragos
approved these changes
Mar 12, 2025
Contributor
|
/git merge
|
Contributor
|
/fm sync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new settings:
AudioUltra
view.tsxwas changed to move provider with settings higher so they can be used by both Audio and Controls.Settings are stored in localStorage between sessions.
Improved styles for audio controls:
Fixed styles and types for uikit's toggle and label:
Added
usePersistentStateandusePersistentJSONStatehooks to core lib. Added tests for them.