Skip to content

feat: OPTIC-1643: Copy Data Manager Quick View link to annotation or region #7122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bmartel merged 21 commits into from
Feb 26, 2025
Merged

feat: OPTIC-1643: Copy Data Manager Quick View link to annotation or region #7122

bmartel merged 21 commits into from
Feb 26, 2025

Conversation

@bmartel
Copy link
Contributor

@bmartel bmartel commented Feb 20, 2025 •
edited
Loading

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

  • Adding the UI to allow copying links to annotations and regions.
  • Added an interface key annotations:copy-link to gate this functionality behind the FF, but also so that this functionality is only restricted to QuickView in LSO/LSE.
  • Refactored a ContextMenu component out of the AnnotationButton component, which gets reused in both AnnotationButton and the RegionControls.
  • Implemented toast notifications on successful copy of the links
  • Replaced the link icon with an updated one, and also added and used a new relation link icon to disambiguate the act of copying links to annotations/regions, and linking regions for the purpose of relation.
Screenshot 2025-02-20 at 6 05 07 PM Screenshot 2025-02-20 at 5 30 40 PM Screenshot 2025-02-20 at 5 29 17 PM Screenshot 2025-02-20 at 5 30 26 PM

What feature flags were used to cover this change?

  • fflag_feat_front_optic_1553_url_based_region_visibility_short

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Quick View > AnnotationButton + RegionControls

@netlify
Copy link

netlify bot commented Feb 20, 2025 •
edited
Loading

✅ Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 04e2619
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67bd6c99190eda00081ecd5f
😎 Deploy Preview https://deploy-preview-7122--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Feb 20, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 04e2619
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67bd6c991400ad0008467215
😎 Deploy Preview https://deploy-preview-7122--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bmartel bmartel changed the title Fb optic 1643 feat: OPTIC-1643: Copy Data Manager Quick View link to annotation or region Feb 21, 2025
@bmartel
Only show annotation and region copy link options if the interface is…
b1fcdbb 
… set, and gate that setting behind the same FF
@MihajloHoma
Copy link
Contributor

MihajloHoma commented Feb 24, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: 16 files changed, 75 insertions(+), 62 deletions(-)

@bmartel
Copy link
Contributor Author

bmartel commented Feb 24, 2025

@yyassi-heartex Can you re-review the two last commits.

  1. Test fixes
  2. I realized when playing around with this feature more, that predictions could not be linked to 🤯, which is a pretty glaring omission in my opinion. So I fixed it, now it works as I thought it already had 😎

yyassi-heartex
yyassi-heartex reviewed Feb 24, 2025
View reviewed changes
yyassi-heartex
yyassi-heartex approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had 1 question, but overall looks good

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Feb 25, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: 14 files changed, 101 insertions(+), 20 deletions(-)

@bmartel bmartel merged commit b0783d8 into develop Feb 26, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yyassi-heartex yyassi-heartex yyassi-heartex approved these changes

Assignees

No one assigned

Labels

Confirmed feat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bmartel @MihajloHoma @yyassi-heartex @robot-ci-heartex