fix: OPTIC-1509: Fix information exposure when tasks import failed #7004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: label_studio/data_import/models.py
Did you find this useful? React with a 👍 or 👎 |
mcanu
changed the title
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7004 +/- ##
========================================
Coverage 76.97% 76.98%
========================================
Files 175 175
Lines 14178 14181 +3
========================================
+ Hits 10914 10917 +3
Misses 3264 3264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yyassi-heartex
approved these changes
Jan 31, 2025
Contributor
Author
|
/git merge develop
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
We got this code scanning alert https://github.com/HumanSignal/label-studio/security/code-scanning/785
Essentially we were showing the uploaded file full paths when importing failed. Now we are only showing the file name so the user knows which file failed.
Before:
After:
What does this fix?
Security issue by exposing internal info.
What is the new behavior?
Only show the file name.
What is the current behavior?
Showing the full file path
Does this PR introduce a breaking change?
(check only one)
Which logical domain(s) does this change affect?
Import