Skip to content

refactor: OPTIC-1415: Remove Stale Feature Flag - ff_back_dev_3865_filters_anno_171222_short #6758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
luarmr wants to merge 1 commit into from
Closed

refactor: OPTIC-1415: Remove Stale Feature Flag - ff_back_dev_3865_filters_anno_171222_short #6758

luarmr wants to merge 1 commit into from

Conversation

@luarmr
Copy link
Contributor

@luarmr luarmr commented Dec 5, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Removing a FF that was stale for a few months.
Pushing this code against after develop being back again

WHEN REVIEW
CHECK THE STALE VALUE FIRST

@netlify
Copy link

netlify bot commented Dec 5, 2024 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 09063a5
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6750eea0f4afb30008ff969b

@netlify
Copy link

netlify bot commented Dec 5, 2024 •
edited
Loading

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 09063a5
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6750eea039186b0008212963

@codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (83ee25a) to head (09063a5).
Report is 79 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #6758   +/-   ##
========================================
  Coverage    76.77%   76.77%           
========================================
  Files          170      170           
  Lines        13944    13944           
========================================
  Hits         10706    10706           
  Misses        3238     3238
Flag Coverage Δ
pytests 76.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr luarmr closed this Jan 8, 2025
@luarmr luarmr deleted the fb-optic-1415/remove-stale-feature-flag---second-attempt-ffbackdev3865filtersanno171222short branch September 19, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yyassi-heartex yyassi-heartex yyassi-heartex approved these changes

Assignees

No one assigned

Labels

Confirmed refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luarmr @yyassi-heartex @robot-ci-heartex