fix: LEAP-1651: Properly update meta text for regions #6726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meta text is saved in regions by Normalization mixin and it's serialized into every result of this region. When we update the meta text we should get this value again from region, not previously stored one in result. So the priority of sources for meta value was changed. Plus "control meta" was removed.
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
It was a model field, so controlled state went through MST update anyway. And it's saved to actual meta in two places, so we can just get the real value there and make input uncontrolled.
hlomzik
commented
Nov 27, 2024
yyassi-heartex
approved these changes
Nov 27, 2024
Contributor
|
/git merge
|
bmartel
approved these changes
Nov 27, 2024
Contributor
bmartel
left a comment
bmartel
left a comment
There was a problem hiding this comment.
Nice cleanup and context, this will help a lot in furthering our code cleanups!
MihajloHoma
approved these changes
Nov 28, 2024
area.meta is always there, at least as an empty object, so we have to check keys.
So it will be saved in any case. Bug was found by tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta text is saved in regions by Normalization mixin and it's serialized into every result of this region. When we update the meta text we should get this value again from region, not previously stored one in result.
So the priority of sources for meta value was changed. Plus "control meta" was removed.
normInputis also removed, it was an excess field.PR fulfills these requirements
Change has impacts in these area(s)
Describe the reason for change
Meta text was not saved during annotation update, because the old saved value took precedence in serialization.
Does this PR introduce a breaking change?
It changes behaviour of meta data saving, but that's a rare feature with two data fields saved, easy to track.
What level of testing was included in the change?