Skip to content

fix: LEAP-1620: Ignore prefixes for storage url resolving #6568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
triklozoid merged 1 commit into from
Oct 29, 2024
Merged

fix: LEAP-1620: Ignore prefixes for storage url resolving #6568

triklozoid merged 1 commit into from
Oct 29, 2024

Conversation

@triklozoid
Copy link
Contributor

@triklozoid triklozoid commented Oct 29, 2024

  • remove recently added prefix check, because it broke existing user pipelines

@github-actions github-actions bot added the fix label Oct 29, 2024
@netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 76fb366
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6720c0f759ef7e000836d598

@netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 76fb366
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6720c0f789481e00086ae8b7

@codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.72%. Comparing base (ce09fbd) to head (76fb366).
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #6568      +/-   ##
===========================================
- Coverage    76.72%   76.72%   -0.01%     
===========================================
  Files          169      169              
  Lines        13820    13818       -2     
===========================================
- Hits         10604    10602       -2     
  Misses        3216     3216
Flag Coverage Δ
pytests 76.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@triklozoid triklozoid merged commit 70a008f into develop Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleylima wesleylima wesleylima approved these changes

@yyassi-heartex yyassi-heartex yyassi-heartex approved these changes

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@triklozoid @wesleylima @yyassi-heartex