Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new File System (FS) drain adapter to write evlog wide-events to local NDJSON files, along with documentation and an agent skill for AI-assisted log analysis.
Changes:
- Introduce
evlog/fsadapter with file rotation + retention cleanup + auto.gitignore. - Add
skills/analyze-logsfor reading.evlog/logs/*.jsonland documenting analysis patterns. - Update docs/metadata/templates to reference the FS adapter and reorganized public skill naming.
Reviewed changes
Copilot reviewed 19 out of 26 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| skills/evlog/SKILL.md | Adds FS adapter row to the drain adapters table. |
| skills/analyze-logs/SKILL.md | New skill describing how to find and analyze FS drain output. |
| packages/evlog/tsdown.config.ts | Adds build entrypoint for the FS adapter. |
| packages/evlog/test/adapters/fs.test.ts | Adds unit tests for FS adapter behavior (gitignore, rotation, cleanup). |
| packages/evlog/src/adapters/fs.ts | Implements the FS drain (write/rotate/cleanup/gitignore). |
| packages/evlog/package.json | Exports evlog/fs entry and types mapping. |
| apps/playground/server/plugins/evlog-drain.ts | Enables FS drain in the playground app. |
| apps/docs/content/4.adapters/7.fs.md | New documentation page for the FS adapter. |
| apps/docs/content/4.adapters/1.overview.md | Adds FS adapter link and overview card. |
| apps/docs/content/1.getting-started/4.agent-skills.md | Updates skill list and adds log analysis section/prompts. |
| apps/docs/content/0.landing.md | Adds mention of FS drain enabling local NDJSON for agents. |
| apps/docs/app/components/features/FeatureAgentReady.vue | Updates “agent ready” pill to mention local NDJSON files. |
| apps/docs/app/components/features/FeatureAdapters.vue | Updates feature blurb to include “+ File System”. |
| AGENTS.md | Updates references to the new public skill path and adds analyze-logs. |
| .github/workflows/semantic-pull-request.yml | Adds fs to allowed PR scopes. |
| .github/pull_request_template.md | Documents fs as an allowed scope. |
| .agents/skills/create-framework-integration/SKILL.md | Updates “update public skill” step to new skill path. |
| .agents/skills/create-enricher/SKILL.md | Updates “update public skill” step to new skill path. |
| .agents/skills/create-adapter/SKILL.md | Updates “update public skill” step to new skill path. |
Comments suppressed due to low confidence (1)
apps/playground/server/plugins/evlog-drain.ts:1
createFsDrain()ultimately writes via async fs calls; invokingfsDrain(ctx)withoutawait(and without making the hook handlerasync) can lead to unhandled rejections and/or the process finishing the hook before the write completes. Make the hook callbackasyncandawait fsDrain(ctx)(or return the Promise) so failures propagate and writes complete deterministically.
// import { createAxiomDrain } from 'evlog/axiom'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the File System (FS) adapter for logging and updates the documentation and agent skills to reflect this addition. It also reorganizes skill documentation to use
skills/review-logging-patternsas the main user-facing skill, and introduces a newanalyze-logsskill for AI-assisted log analysis.