fix(sveltekit): remove @sveltejs/kit optional peer dependency#172
Merged
fix(sveltekit): remove @sveltejs/kit optional peer dependency#172
Conversation
The SvelteKit integration defines its own compatible types locally and never imports from @sveltejs/kit. Having it as a peer dependency causes npm to resolve its full transitive tree, pulling in @sveltejs/vite-plugin-svelte@7 which requires vite@^8.0.0 — conflicting with projects using Vite 7.x (e.g. Nuxt 4). Closes #171
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@sveltejs/kitfrompeerDependenciesandpeerDependenciesMeta, it was never imported (the SvelteKit integration defines its own compatible types locally), so npm was unnecessarily resolving its transitive dependency treeERESOLVEfailures when installing[email protected]in non-SvelteKit projects (e.g. Nuxt 4) where@sveltejs/vite-plugin-svelte@7pulls invite@^8.0.0, conflicting with Vite 7.xCloses #171