fix: group otlp batch by resource identity instead of using first event#158
Merged
HugoRCD merged 1 commit intoHugoRCD:mainfrom Mar 10, 2026
Merged
Conversation
|
@shubh73 is attempting to deploy a commit to the HRCD Projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thank you for following the naming conventions! 🙏 |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
sendBatchToOTLPuses the first event's resource attributes for all events in the batch. When a batch contains events from multiple services or environments (e.g. a queue consumer or telemetry relay) every event gets the first event'sservice.nameanddeployment.environment— so logs frompaymentsshow up asauth.We hit this in production running a workers queue consumer that aggregates events from multiple services and flushes them in a single
sendBatchToOTLPcall. We had to inline the otlp adapter in our app to work around it.This PR groups events by (service, environment) before building the payload, so each group gets its own
resourceLogsentry with correct resource attributes.📝 Checklist
Note
This PR was written with AI assistance.