Skip to content

Missing doTopCall() overriding in HtmlUnitContextFactory #1057

@RuralHunter

Description

@RuralHunter

It seems ContextFactory added another new doTopCall() method with signature in latest 4.18.0:
protected Object doTopCall(Script script, Context cx, Scriptable scope, Scriptable thisObj)

HtmlUnitContextFactory overrided the old doTopCall method but doesn't override the new one. It leads all the js execution from the new doTopCall() timeout if I set js timeout in WebClient. The reason is the TimeoutContext.startTime_ is 0 without the overriding to call TimeoutContext.startClock().

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions