Repository navigation
fix(host): allow manual resume through active pauses - #55
Conversation
审查者指南允许显式的“立即恢复”操作绕过全局暂停和会话暂停,仅对这一次手动发送生效,同时保留自动恢复和自主循环活动的暂停强制机制;新增了针对性的回归测试,并将其接入测试套件。 绕过暂停执行手动恢复的时序图sequenceDiagram
actor User
participant Runner as AutoContinueRunner
participant Session as Session
User->>Runner: resumeNow(sessionId)
Runner->>Runner: fire(sessionId, MANUAL_NOTIFICATION_REASON, true)
Runner->>Runner: evaluate manualResume
alt manual resume
Runner->>Session: send manual notification
else automatic recovery or loop
Runner->>Runner: check global and session pauses
alt paused
Runner-->>Session: skip send
else not paused
Runner->>Session: send notification
end
end
文件级变更
提示和命令与 Sourcery 交互
自定义你的使用体验访问你的控制面板以:
获取帮助Original review guide in EnglishReviewer's GuideAllows the explicit Resume now action to bypass global and session pauses for its single manual send, while retaining pause enforcement for automatic recovery and autonomous-loop activity; adds focused regression coverage and wires it into the test suite. Sequence diagram for manual resume bypassing pausessequenceDiagram
actor User
participant Runner as AutoContinueRunner
participant Session as Session
User->>Runner: resumeNow(sessionId)
Runner->>Runner: fire(sessionId, MANUAL_NOTIFICATION_REASON, true)
Runner->>Runner: evaluate manualResume
alt manual resume
Runner->>Session: send manual notification
else automatic recovery or loop
Runner->>Runner: check global and session pauses
alt paused
Runner-->>Session: skip send
else not paused
Runner->>Session: send notification
end
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
嘿——我已经审阅了你的更改,看起来很棒!
Sourcery 评估
需要人工审阅。 如果绕过暂停的条件不正确,按下“恢复”可能会在全局或会话处于暂停状态时发送助手后续消息,而该后续消息可能触发外部可见的工作或工具操作,并且这些操作无法通过回滚此更改来撤销。影响范围仅限于明确执行的“恢复”操作;通过回滚或再次暂停,可以阻止未来的行为。
Original comment in English
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. If the pause-bypass condition is wrong, pressing Resume can send an assistant follow-up despite a global or session pause, and that follow-up may trigger externally visible work or tool actions that cannot be undone by reverting the change. The impact is bounded to explicit Resume actions and future behavior can be stopped by reverting or re-pausing.
|
@SourceryAI title |
…ing-pause fix(host): allow manual resume through active pauses
Resume now is an explicit user action, but the engine's send-time pause checks also blocked it. The manual notification reason can now bypass global and session pauses for that send; automatic recovery and autonomous-loop sends continue to honor both pause states.
Validation:
npm run build,npm run typecheck,npm test,npm run test:runtime, andgit diff --checkpass. Runtime coverage uses pinned DSH 0.1.7-rc.2 and 0.2.0-rc.1 fixtures.The pinned plugin checker passes 18 checks with no failures or warnings; the Hub catalog check is skipped because the catalog could not be read.
Sourcery 摘要
允许手动恢复操作绕过自动继续暂停,同时不会削弱对自动发送的暂停强制执行。
新功能:
错误修复:
测试:
Original summary in English
Sourcery 摘要
允许在全局暂停或会话暂停生效期间通过显式手动恢复发送一次,同时继续对自动发送和进行中的设置编辑实施暂停限制。
新功能:
错误修复:
测试:
Original summary in English
Summary by Sourcery
Allow explicit manual resumes through active pauses while preserving pause enforcement for automated sends and in-flight settings edits.
New Features:
Bug Fixes:
Tests: