Skip to content

[email protected] 3.9.6#80175

Closed
branchv wants to merge 3 commits intoHomebrew:masterfrom
branchv:[email protected]
Closed

[email protected] 3.9.6#80175
branchv wants to merge 3 commits intoHomebrew:masterfrom
branchv:[email protected]

Conversation

@branchv
Copy link
Copy Markdown
Member

@branchv branchv commented Jun 28, 2021 •
edited
Loading

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jun 28, 2021
bayandin
bayandin reviewed Jun 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@bayandin bayandin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're new version of resources available: setuptools 57.0.0 and pip 21.1.3

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Jun 28, 2021

Do you mind cherry-picking my commit from #80052 so we don't have to re-run CI for it?

@carlocab @branchv
[email protected]: set RPATH to $HOMEBREW_PREFIX/lib
028cfbc 
This allows the `ctypes` module to be able to find libraries installed
into a non-`/usr/local` prefix with `ctypes.cdll.LoadLibrary`.

Closes qmk/qmk_cli#60
Resolves Homebrew/discussions#1737
@branchv
Copy link
Copy Markdown
Member Author

branchv commented Jun 28, 2021

Do you mind cherry-picking my commit from #80052 so we don't have to re-run CI for it?

certainly, hope I did that right 😅

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Jun 28, 2021

Excellent, thank you!

@carlocab carlocab mentioned this pull request Jun 28, 2021
Closed
6 tasks
@carlocab
Copy link
Copy Markdown
Member

carlocab commented Jun 30, 2021

ARM

brew install --only-dependencies cake
brew install cake
brew test --retry --verbose easyengine
brew test --retry --verbose lean
brew test --retry --verbose mathlibtools
brew test --retry --verbose monkeysphere
brew install --only-dependencies paket
brew install paket
brew test --retry --verbose spack

Big Sur

Error: 15 failed steps!
brew test --retry --verbose asuka
brew test --retry --verbose corral
brew test --retry --verbose creduce
brew test --retry --verbose easyengine
brew test --retry --verbose hyperkit
brew test --retry --verbose influxdb
brew test --retry --verbose lean
brew test --retry --verbose llvm@7
brew test --retry --verbose llvm@8
brew test --retry --verbose llvm@9
brew test --retry --verbose mathlibtools
brew test --retry --verbose monkeysphere
brew test --retry --verbose ponyc
brew test --retry --verbose spack
brew test --retry --verbose wasm-pack

Catalina

Error: 20 failed steps!
brew install --only-dependencies creduce
brew install creduce
brew test --retry --verbose easyengine
brew install --only-dependencies --include-test haskell-language-server
brew test --retry --verbose haskell-language-server
brew test --retry --verbose hyperkit
brew install --only-dependencies idris
brew install idris
brew test --retry --verbose lean
brew install llvm@7
brew install llvm@8
brew install llvm@9
brew test --retry --verbose mathlibtools
brew install --only-dependencies oclgrind
brew install oclgrind
brew install --only-dependencies odin
brew install odin
brew test --retry --verbose spack
brew test --retry --verbose subversion
brew test --retry --verbose wasm-pack

Mojave

Error: 8 failed steps!
brew test --retry --verbose easyengine
brew test --retry --verbose hyperkit
brew test --retry --verbose lean
brew test --retry --verbose mathlibtools
brew test --retry --verbose opencascade
brew test --retry --verbose spack
brew test --retry --verbose swift
brew test --retry --verbose wasm-pack

Most of these aren't unexpected, but I think we need to take a look at spack, at least. Plus all the extra Catalina failures, but that might just be an out of space on device error.

@branchv
Copy link
Copy Markdown
Member Author

branchv commented Jul 1, 2021

spack is a legimate issue, filed spack/spack#24644

@adamjstewart adamjstewart mentioned this pull request Jul 2, 2021
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 3, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 3, 2021
@carlocab carlocab added in progress Stale bot should stay away and removed stale No recent activity labels Jul 3, 2021
@carlocab
Copy link
Copy Markdown
Member

carlocab commented Jul 3, 2021

Looks like the spack issue will be fixed by spack/spack#24686. In the meantime, maybe we can just make spack depend on [email protected].

@branchv
Copy link
Copy Markdown
Member Author

branchv commented Jul 3, 2021

Agreed, I'm not near my computer but I did try the latest [email protected] locally and spack was indeed happy

tgamblin added a commit to spack/spack that referenced this pull request Jul 3, 2021
@adamjstewart @tgamblin
Fix fetching for Python 3.9.6 (#24686)
3b94e22 
When using Python 3.9.6, Spack is no longer able to fetch anything. Commands like `spack fetch` and `spack install` all break.

Python 3.9.6 includes a [new change](https://github.com/python/cpython/pull/25853/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873eR462) that means that `scheme` must be a string, it cannot be None. The solution is to use an empty string like the method default.

Fixes #24644. Also see Homebrew/homebrew-core#80175 where this issue was discovered by CI. Thanks @branchvincent for reporting such a serious issue before any actual users encountered it!

Co-authored-by: Todd Gamblin <[email protected]>
@branchv branchv mentioned this pull request Jul 3, 2021
Closed
6 tasks
carlocab
carlocab approved these changes Jul 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining failures look pre-existing (cf. #79624). Thanks for your work here, @branchvincent!

@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Jul 3, 2021

:shipit: @carlocab has triggered a merge.

ChristianTackeGSI pushed a commit to FairRootGroup/spack that referenced this pull request Jul 6, 2021
@adamjstewart @tgamblin @ChristianTackeGSI
Fix fetching for Python 3.9.6 (spack#24686)
ed7911e 
When using Python 3.9.6, Spack is no longer able to fetch anything. Commands like `spack fetch` and `spack install` all break.

Python 3.9.6 includes a [new change](https://github.com/python/cpython/pull/25853/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873eR462) that means that `scheme` must be a string, it cannot be None. The solution is to use an empty string like the method default.

Fixes spack#24644. Also see Homebrew/homebrew-core#80175 where this issue was discovered by CI. Thanks @branchvincent for reporting such a serious issue before any actual users encountered it!

Co-authored-by: Todd Gamblin <[email protected]>
(cherry picked from commit 3b94e22)
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carlocab carlocab carlocab approved these changes

+1 more reviewer

@bayandin bayandin bayandin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bump-formula-pr PR was created using `brew bump-formula-pr` in progress Stale bot should stay away outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@branchv @carlocab @BrewTestBot @bayandin