Skip to content

[email protected]: update Big Sur patch #74745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rohitpk wants to merge 1 commit into from
Closed

[email protected]: update Big Sur patch #74745

rohitpk wants to merge 1 commit into from

Conversation

@rohitpk
Copy link
Contributor

@rohitpk rohitpk commented Apr 7, 2021 •
edited
Loading

The issue addresses the part where MACOSX_DEPLOYMENT_TARGET comes to be out as an integer instead of String(Float). This seems to be an issue with the new MacOS's BigSur update and has been solved in python3.9 (MACOSX_DEPLOYMENT_TARGET). However, there's no fix for python3.7 yet.
(python/cpython#24341)

To reproduce the error:

Environment
pip version: 20.3.4
Python version: 3.7.10
OS: macOS 11.2.3

Command
pip install "cffi >=1.1" failed

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added legacy Relates to a versioned @ formula no ARM bottle Formula has no ARM bottle labels Apr 7, 2021
@Bo98
Copy link
Member

Bo98 commented Apr 7, 2021

We already apply a patch to MACOSX_DEPLOYMENT_TARGET. This patch has since been revised so I think we should just update the patch.

@rohitpk
Copy link
Contributor Author

rohitpk commented Apr 7, 2021 •
edited
Loading

@Bo98 thanks! Can you please point me to that patch?

@Bo98
Copy link
Member

Bo98 commented Apr 7, 2021 •
edited
Loading

I'm referring to the one on line 84. I've updated it now to incorporate the changes in the PR you linked so you can change the URL to:

https://raw.githubusercontent.com/Homebrew/formula-patches/c4bc563a8d008ebd0e8d927c043f6dd132d3ba89/python/big-sur-3.7.patch
sha256: 67c99bdf0bbe0a640d70747aad514cd74602e7c4715fd15f1f9863eef257735e

rohitpk
rohitpk commented Apr 7, 2021
View reviewed changes
Copy link
Contributor Author

@rohitpk rohitpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out -- updated the right URL for the patch.

@carlocab carlocab changed the title Update [email protected] [email protected]: update Big Sur patch Apr 8, 2021
@rohitpk
Copy link
Contributor Author

rohitpk commented Apr 9, 2021

@Bo98 can you please approve the PR.

@rohitpk
Copy link
Contributor Author

rohitpk commented Apr 19, 2021

@Bo98 following up on this -- could you please approve?

@Bo98
Copy link
Member

Bo98 commented Apr 20, 2021

Apologies - I must have not noticed the prior ping. Can you bump the revision here too?

@rohitpk
Update [email protected]
9632f8e 
The issue addresses the part where `MACOSX_DEPLOYMENT_TARGET` comes to be out as an integer instead of String(Float). This seems to be an issue with the new MacOS's BigSur update and has been solved in `python3.9` (MACOSX_DEPLOYMENT_TARGET).  However, there's no fix for python3.7 yet.
- Pointed to the right patch for the fix
- Revision bump

(python/cpython#24341)
@rohitpk rohitpk force-pushed the python3.7-Macos-Bigsur-fix branch from 75bd2dd to 9632f8e Compare April 23, 2021 07:34
@rohitpk
Copy link
Contributor Author

rohitpk commented Apr 23, 2021

@Bo98 done.

@rohitpk
Copy link
Contributor Author

rohitpk commented Apr 27, 2021

@Bo98 you missed it again :(

Bo98
Bo98 approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rohitpk!

@BrewTestBot
Copy link
Contributor

BrewTestBot commented Apr 27, 2021

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label May 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Bo98 Bo98 Bo98 approved these changes

Assignees

No one assigned

Labels

legacy Relates to a versioned @ formula no ARM bottle Formula has no ARM bottle outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohitpk @Bo98 @BrewTestBot