eigen: Remove deprecated cmake module #198963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-linnane
approved these changes
Nov 25, 2024
SMillerDev
approved these changes
Nov 25, 2024
Contributor
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
carlocab
added
the
CI-skip-recursive-dependents
Member
|
Doesn't seem like a related issue. Disabling fail-fast. |
SMillerDev
added
the
CI-no-fail-fast-deps
akretz
force-pushed
the
remove-eigen-module
branch
from
c5bcda0 to
4749a45
Compare
Contributor
Author
|
Seems like the macOS 14 CI server has not been updated to Xcode 16. I can retrigger once that's done. |
Contributor
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sarlinpe
added a commit
to colmap/colmap
that referenced
this pull request
Nov 27, 2024
Since Homebrew/homebrew-core#198963 and actions/runner-images#10984 have both been fixed.
sarlinpe
added a commit
to colmap/colmap
that referenced
this pull request
Dec 27, 2024
Since Homebrew/homebrew-core#198963 and actions/runner-images#10984 have both been fixed.
HernandoR
pushed a commit
to HernandoR/colmap
that referenced
this pull request
Dec 30, 2024
Since Homebrew/homebrew-core#198963 and actions/runner-images#10984 have both been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?See #198775 (comment) and #198775 (comment) for the reasoning behind removing the Eigen3 CMake module in favor of the CMake config. It has been removed upstream.
This fixes #198772 and fixes ceres-solver/ceres-solver#1118