Skip to content

libnghttp2 nghttp2 1.62.1 #171634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

libnghttp2 nghttp2 1.62.1 #171634

wants to merge 2 commits into from

Conversation

bevanjkay
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Sorry, something went wrong.

@bevanjkay bevanjkay changed the title libnghttp2 1.62.0 libnghttp2 nghttp2 1.62.0 May 14, 2024
@github-actions github-actions bot added CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing labels May 14, 2024
@bevanjkay bevanjkay force-pushed the libnghttp2-1.14.0 branch 2 times, most recently from cff6848 to 7fbc4a3 Compare May 14, 2024 03:32
@bevanjkay bevanjkay force-pushed the libnghttp2-1.14.0 branch from 7fbc4a3 to cbb965b Compare May 22, 2024 06:48
@bevanjkay bevanjkay force-pushed the libnghttp2-1.14.0 branch from cbb965b to 4752856 Compare May 28, 2024 11:46
@bevanjkay bevanjkay added CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner and removed CI-linux-self-hosted Build on Linux self-hosted runner labels May 28, 2024
@bevanjkay bevanjkay changed the title libnghttp2 nghttp2 1.62.0 libnghttp2 nghttp2 1.62.1 May 28, 2024
@bevanjkay bevanjkay force-pushed the libnghttp2-1.14.0 branch from 4752856 to 85d2e35 Compare May 28, 2024 11:57
@github-actions github-actions bot added the CI-linux-self-hosted Build on Linux self-hosted runner label May 28, 2024
@bevanjkay bevanjkay removed the CI-linux-self-hosted Build on Linux self-hosted runner label May 28, 2024
@bevanjkay bevanjkay force-pushed the libnghttp2-1.14.0 branch from 85d2e35 to 7d65796 Compare May 28, 2024 12:04
@github-actions github-actions bot added the CI-linux-self-hosted Build on Linux self-hosted runner label May 28, 2024
@bevanjkay bevanjkay removed the CI-linux-self-hosted Build on Linux self-hosted runner label May 28, 2024
@bevanjkay bevanjkay force-pushed the libnghttp2-1.14.0 branch from 7d65796 to 28ae32c Compare May 28, 2024 12:13
@github-actions github-actions bot added the CI-linux-self-hosted Build on Linux self-hosted runner label May 28, 2024
@bevanjkay bevanjkay added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed CI-linux-self-hosted Build on Linux self-hosted runner labels May 28, 2024
@bevanjkay bevanjkay force-pushed the libnghttp2-1.14.0 branch from 28ae32c to 38d2e0c Compare May 28, 2024 12:34
@github-actions github-actions bot added the CI-linux-self-hosted Build on Linux self-hosted runner label May 28, 2024
@bevanjkay bevanjkay removed the CI-linux-self-hosted Build on Linux self-hosted runner label May 28, 2024
@bevanjkay bevanjkay force-pushed the libnghttp2-1.14.0 branch from 38d2e0c to 58af4f4 Compare May 28, 2024 12:35
@github-actions github-actions bot added the CI-linux-self-hosted Build on Linux self-hosted runner label May 28, 2024
@bevanjkay bevanjkay removed the CI-linux-self-hosted Build on Linux self-hosted runner label May 28, 2024
@bevanjkay bevanjkay force-pushed the libnghttp2-1.14.0 branch from 58af4f4 to c3367f7 Compare May 28, 2024 12:52
@github-actions github-actions bot added the CI-linux-self-hosted Build on Linux self-hosted runner label May 28, 2024
@github-actions github-actions bot added the CI-linux-self-hosted Build on Linux self-hosted runner label May 28, 2024
@carlocab carlocab removed CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing labels May 28, 2024
carlocab added a commit to Homebrew/brew that referenced this pull request May 28, 2024
@carlocab
formula_auditor: add exemption for nghttp2
fcd5b29 
Needed for Homebrew/homebrew-core#171634 due to nghttp2/nghttp2#2194.

I've avoided adding an allowlist for now because I really don't want to
see this list grow.
@carlocab carlocab mentioned this pull request May 28, 2024
Merged
7 tasks
@carlocab carlocab removed the CI-no-bottle-cache Disable bottle cache label May 28, 2024
bevanjkay and others added 2 commits May 29, 2024 16:34
@bevanjkay @carlocab
libnghttp2 1.62.1
41f44c7
@bevanjkay @carlocab
nghttp2 1.62.1
1bf2b90 
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
carlocab added a commit to Homebrew/brew that referenced this pull request May 29, 2024
@carlocab
formula_auditor: add exemption for nghttp2
4be3f8e 
Needed for Homebrew/homebrew-core#171634 due to nghttp2/nghttp2#2194.
@carlocab carlocab added CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels May 29, 2024
@carlocab carlocab force-pushed the libnghttp2-1.14.0 branch from dbded26 to 1bf2b90 Compare May 29, 2024 08:36
@carlocab carlocab requested a review from a team as a code owner May 29, 2024 08:36
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing labels May 29, 2024
@carlocab carlocab removed automerge-skip `brew pr-automerge` will skip this pull request CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing labels May 29, 2024
carlocab
carlocab reviewed May 29, 2024
View reviewed changes
CODEOWNERS
@@ -16,6 +16,7 @@ tap_migrations.json @Homebrew/tsc @MikeMcQuaid
LICENSE.txt @Homebrew/tsc @MikeMcQuaid
.github/workflows/ @Homebrew/core @MikeMcQuaid

audit_exceptions/linux_only_gcc_dependency_allowlist.json @Homebrew/tsc @carlocab
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
audit_exceptions/linux_only_gcc_dependency_allowlist.json @Homebrew/tsc @carlocab
audit_exceptions/linux_only_gcc_dependency_allowlist.json @Homebrew/tsc @Bo98

@Bo98 you ok if we do this instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
audit_exceptions/linux_only_gcc_dependency_allowlist.json @Homebrew/tsc @carlocab
audit_exceptions/linux_only_gcc_dependency_allowlist.json @Homebrew/tsc

I think it's fine for it to be just the TSC here.

@carlocab carlocab added the CI-no-bottle-cache Disable bottle cache label May 29, 2024
MikeMcQuaid
MikeMcQuaid reviewed May 29, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once we figure decode on the CODEOWNERS (or move to another PR).

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jun 20, 2024
@github-actions github-actions bot closed this Jul 6, 2024
@p-linnane p-linnane deleted the libnghttp2-1.14.0 branch August 2, 2024 20:51
@carlocab carlocab mentioned this pull request Aug 31, 2024
Merged
6 tasks
carlocab added a commit that referenced this pull request Aug 31, 2024
@carlocab
CODEOWNERS: add linux_only_gcc_dependency_allowlist
8a4e490 
Needed after #182969. See also #171634.
@carlocab carlocab mentioned this pull request Aug 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid

@Bo98 Bo98

@cho-m cho-m

@carlocab carlocab

@chenrui333 chenrui333

@iMichka iMichka

Assignees
No one assigned
Labels
CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner CI-no-bottle-cache Disable bottle cache CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. long dependent tests Set a long timeout for dependent testing stale No recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bevanjkay @MikeMcQuaid @Bo98 @chenrui333 @iMichka @cho-m @carlocab