Adding the header option to CurlDownloadStrategy.#6545
Merged
Conversation
It's easy to access github private resources later through specific `header` settings. e.g. ``` cask 'XXXX' do ... url "https://raw.githubusercontent.com/....", header : "Authorization: token #{ENV['HOMEBREW_GITHUB_API_TOKEN']}" ... end ```
MikeMcQuaid
approved these changes
Oct 7, 2019
MikeMcQuaid
left a comment
Member
There was a problem hiding this comment.
Seems reasonable to me. @reitermarkus?
MikeMcQuaid
reviewed
Oct 7, 2019
reitermarkus
approved these changes
Oct 7, 2019
Member
|
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @maboloshi! |
11 tasks
reitermarkus
pushed a commit
to Homebrew/homebrew-cask
that referenced
this pull request
Oct 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g.
It's easy to access github private resources later through specific
headersettings.Write the following code, such as
~/.bashrc,~/.zshrc, etc.<personal access token>: A personal access token for the GitHub API, requiresrepoaccess permission (full control of private repositories).brew stylewith your changes locally?brew testswith your changes locally?