Fix tap migrations without full scope#20932
Merged
MikeMcQuaid merged 1 commit intomainfrom Oct 24, 2025
Merged
Conversation
We no longer require `user/repo/tap` format in tap migrations and allow them to point to themselves when moving from a formula to a cask.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes tap migration handling to support migrations without full user/repo/tap scope format and allows self-referential migrations when moving from a formula to a cask.
Key changes:
- Replaced the fallback logic
|| [Tap.fetch(new_tap_name), name]with explicit conditional handling - Added support for tap migrations that specify only a name (without
/) to reference items in the same tap - Removed the warning message for self-referential migrations and changed the condition to only process when source and target differ
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/formulary.rb | Updated tap migration logic to handle migrations without full scope and allow self-references for formula migrations |
| Library/Homebrew/cask/cask_loader.rb | Updated tap migration logic to handle migrations without full scope and allow self-references for cask migrations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ZhongRuoyu
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer require
user/repo/tapformat in tap migrations and allow them to point to themselves when moving from a formula to a cask.